Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 250713002: Reformats how auth message is converted to string. (Closed)

Created:
6 years, 8 months ago by mark a. foltz
Modified:
6 years, 7 months ago
Reviewers:
Munjal (Google)
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Reformats how auth message is converted to string for logging, so it doesn't log binary data and prints on one line. TESTED=chrome --vmodule="cast_auth*=1" BUG=365452 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/browser/extensions/api/cast_channel/cast_message_util.cc View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mark a. foltz
6 years, 8 months ago (2014-04-24 22:19:44 UTC) #1
Munjal (Google)
LGTM
6 years, 7 months ago (2014-04-28 17:17:26 UTC) #2
mark a. foltz
The CQ bit was checked by mfoltz@chromium.org
6 years, 7 months ago (2014-04-28 18:38:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mfoltz@chromium.org/250713002/1
6 years, 7 months ago (2014-04-28 18:39:45 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 00:05:29 UTC) #5
Message was sent while issue was closed.
Change committed as 266705

Powered by Google App Engine
This is Rietveld 408576698