Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1324)

Unified Diff: runtime/vm/cpu_arm.cc

Issue 2507113004: Adjust ARM feature detection to note the Xiaomi MI5 also fails to support integer division in A32 c… (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/cpu_arm.cc
diff --git a/runtime/vm/cpu_arm.cc b/runtime/vm/cpu_arm.cc
index 16f2e182101adac21655952c406178860c9a1ea7..e5a1dd9bb77c618cefa3db058a7b73dd64a35e46 100644
--- a/runtime/vm/cpu_arm.cc
+++ b/runtime/vm/cpu_arm.cc
@@ -207,14 +207,15 @@ void HostCPUFeatures::InitOnce() {
// - Qualcomm Krait CPUs (QCT APQ8064) in Nexus 4 and 7 incorrectly report
// that they lack integer division.
// - Marvell Armada 370/XP incorrectly reports that it has integer division.
- // - The Pixel lacks integer division even though ARMv8 requires it in A32.
+ // - Qualcomm Snapdragon 820/821 CPUs (MSM 8996 and MSM8996pro) in Xiaomi MI5
+ // and Pixel lack integer division even though ARMv8 requires it in A32.
bool is_krait = CpuInfo::FieldContains(kCpuInfoHardware, "QCT APQ8064");
bool is_armada_370xp =
CpuInfo::FieldContains(kCpuInfoHardware, "Marvell Armada 370/XP");
- bool is_pixel = CpuInfo::FieldContains(kCpuInfoHardware, "MSM8996pro");
+ bool is_snapdragon = CpuInfo::FieldContains(kCpuInfoHardware, "MSM8996");
if (is_krait) {
integer_division_supported_ = FLAG_use_integer_division;
- } else if (is_armada_370xp || is_pixel) {
+ } else if (is_armada_370xp || is_snapdragon) {
integer_division_supported_ = false;
} else {
integer_division_supported_ =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698