Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2507113002: Add support for the vbroadcastss instruction. (Closed)

Created:
4 years, 1 month ago by Sébastien Marchand
Modified:
4 years, 1 month ago
CC:
syzygy-changes_googlegroups.com
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

Add support for the vbroadcastss instruction. Committed: https://github.com/google/syzygy/commit/38646919c445f5851ee21a4399b0afbf30f9c916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M syzygy/core/disassembler_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M syzygy/core/disassembler_util_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Sébastien Marchand
PTAL.
4 years, 1 month ago (2016-11-16 17:43:33 UTC) #2
Sigurður Ásgeirsson
lgtm
4 years, 1 month ago (2016-11-16 17:56:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507113002/1
4 years, 1 month ago (2016-11-16 17:58:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/google/syzygy/commit/38646919c445f5851ee21a4399b0afbf30f9c916
4 years, 1 month ago (2016-11-16 18:38:02 UTC) #7
chrisha
4 years, 1 month ago (2016-11-16 19:12:32 UTC) #9
Message was sent while issue was closed.
I can't wait until we can ditch our instrumenter :)

Powered by Google App Engine
This is Rietveld 408576698