Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Issue 2507063004: [ast] Fix typo in {Scope::set_asm_function} method. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ast] Fix typo in {Scope::set_asm_function} method. This fixes the bogus implementation of the function in question and adds test coverage for the deserialization of the corresponding flags from the serialized scope info. Note that the tests so far only cover cases where the module and the function contain context-allocated variables. R=verwaest@chromium.org TEST=cctest/test-parsing/AsmFunctionFlag BUG=v8:5653 Committed: https://crrev.com/28d7c1fb4a9c06014269927ab51dafd69e6d3ea2 Cr-Commit-Position: refs/heads/master@{#41093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -6 lines) Patch
M src/ast/scopes.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 5 chunks +100 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Michael Starzinger
4 years, 1 month ago (2016-11-17 17:16:07 UTC) #3
Toon Verwaest
LGTM, Thanks for fixing this!
4 years, 1 month ago (2016-11-17 19:25:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507063004/1
4 years, 1 month ago (2016-11-18 09:24:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 09:26:39 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 09:27:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28d7c1fb4a9c06014269927ab51dafd69e6d3ea2
Cr-Commit-Position: refs/heads/master@{#41093}

Powered by Google App Engine
This is Rietveld 408576698