Revert of Add Store+Sync to reading list.

Revert of Add Store+Sync to reading list. (patchset #20 id:380001 of https://codereview.chromium.org/2451843002/ )

Reason for revert:
Failing compile on ios-simulator-xcode-clang:

reading_list_store_unittest.cc:75:12: error: no viable conversion from returned value of type 'unique_ptr<TestModelTypeChangeProcessor>' to function return type 'unique_ptr<syncer::ModelTypeChangeProcessor>'
    return processor;
           ^~~~~~~~~

It isn't legal to return a unique_ptr<B> from a function that returns
unique_ptr<A> even if A is a base class. You need to explicitly declare
|processor| to have type unique_ptr<syncer::ModelTypeChangeProcessor>.
I'm not sure why this wasn't picked up by the try bots.

Original issue's description:
> Add Store+Sync to reading list.
> 
> This CL creates a ModelTypeService for reading list.
> This service will store persistent data for the Reading list model and sync
> data between devices.
> 
> The previous store using NSUserDefaults will not be cleaned.
> As it was only accessible from canary behind an experimental flag, no user
> should be affected.
> 
> BUG=661668
> 
> Committed: https://crrev.com/faa080c524c6a80c2ac276359e29dec8cf7946c4
> Cr-Commit-Position: refs/heads/master@{#432845}

TBR=pavely@chromium.org,skym@chromium.org,jif@chromium.org,olivierrobin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661668
Committed: https://chromium.googlesource.com/chromium/src/+/49740e42977be69ae7c1af0f01df1758957c539b

[Matt Giuca, 2016-11-18 01:05:46]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-11-18 01:05:47]

Created Revert of Add Store+Sync to reading list.

[commit-bot: I haz the power, 2016-11-18 01:07:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 01:08:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 01:08:14]

Failed to apply the patch.

[commit-bot: I haz the power, 2016-11-18 02:01:03]

Description was changed from

==========
Revert of Add Store+Sync to reading list. (patchset #20 id:380001 of
https://codereview.chromium.org/2451843002/ )

Reason for revert:
Failing compile on ios-simulator-xcode-clang:

reading_list_store_unittest.cc:75:12: error: no viable conversion from returned
value of type 'unique_ptr<TestModelTypeChangeProcessor>' to function return type
'unique_ptr<syncer::ModelTypeChangeProcessor>'
    return processor;
           ^~~~~~~~~

It isn't legal to return a unique_ptr<B> from a function that returns
unique_ptr<A> even if A is a base class. You need to explicitly declare
|processor| to have type unique_ptr<syncer::ModelTypeChangeProcessor>.
I'm not sure why this wasn't picked up by the try bots.

Original issue's description:
> Add Store+Sync to reading list.
> 
> This CL creates a ModelTypeService for reading list.
> This service will store persistent data for the Reading list model and sync
> data between devices.
> 
> The previous store using NSUserDefaults will not be cleaned.
> As it was only accessible from canary behind an experimental flag, no user
> should be affected.
> 
> BUG=661668
> 
> Committed: https://crrev.com/faa080c524c6a80c2ac276359e29dec8cf7946c4
> Cr-Commit-Position: refs/heads/master@{#432845}

TBR=pavely@chromium.org,skym@chromium.org,jif@chromium.org,olivierrobin@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661668
==========

to

==========
Revert of Add Store+Sync to reading list. (patchset #20 id:380001 of
https://codereview.chromium.org/2451843002/ )

Reason for revert:
Failing compile on ios-simulator-xcode-clang:

reading_list_store_unittest.cc:75:12: error: no viable conversion from returned
value of type 'unique_ptr<TestModelTypeChangeProcessor>' to function return type
'unique_ptr<syncer::ModelTypeChangeProcessor>'
    return processor;
           ^~~~~~~~~

It isn't legal to return a unique_ptr<B> from a function that returns
unique_ptr<A> even if A is a base class. You need to explicitly declare
|processor| to have type unique_ptr<syncer::ModelTypeChangeProcessor>.
I'm not sure why this wasn't picked up by the try bots.

Original issue's description:
> Add Store+Sync to reading list.
>
> This CL creates a ModelTypeService for reading list.
> This service will store persistent data for the Reading list model and sync
> data between devices.
>
> The previous store using NSUserDefaults will not be cleaned.
> As it was only accessible from canary behind an experimental flag, no user
> should be affected.
>
> BUG=661668
>
> Committed: https://crrev.com/faa080c524c6a80c2ac276359e29dec8cf7946c4
> Cr-Commit-Position: refs/heads/master@{#432845}

TBR=pavely@chromium.org,skym@chromium.org,jif@chromium.org,olivierrobin@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661668

Committed: https://crrev.com/49740e42977be69ae7c1af0f01df1758957c539b
Cr-Commit-Position: refs/heads/master@{#433019}
==========

[commit-bot: I haz the power, 2016-11-18 02:01:04]

Patchset 1 (id:??) landed as
https://crrev.com/49740e42977be69ae7c1af0f01df1758957c539b
Cr-Commit-Position: refs/heads/master@{#433019}

[Matt Giuca, 2016-11-18 02:02:53]

Description was changed from

==========
Revert of Add Store+Sync to reading list. (patchset #20 id:380001 of
https://codereview.chromium.org/2451843002/ )

Reason for revert:
Failing compile on ios-simulator-xcode-clang:

reading_list_store_unittest.cc:75:12: error: no viable conversion from returned
value of type 'unique_ptr<TestModelTypeChangeProcessor>' to function return type
'unique_ptr<syncer::ModelTypeChangeProcessor>'
    return processor;
           ^~~~~~~~~

It isn't legal to return a unique_ptr<B> from a function that returns
unique_ptr<A> even if A is a base class. You need to explicitly declare
|processor| to have type unique_ptr<syncer::ModelTypeChangeProcessor>.
I'm not sure why this wasn't picked up by the try bots.

Original issue's description:
> Add Store+Sync to reading list.
>
> This CL creates a ModelTypeService for reading list.
> This service will store persistent data for the Reading list model and sync
> data between devices.
>
> The previous store using NSUserDefaults will not be cleaned.
> As it was only accessible from canary behind an experimental flag, no user
> should be affected.
>
> BUG=661668
>
> Committed: https://crrev.com/faa080c524c6a80c2ac276359e29dec8cf7946c4
> Cr-Commit-Position: refs/heads/master@{#432845}

TBR=pavely@chromium.org,skym@chromium.org,jif@chromium.org,olivierrobin@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661668

Committed: https://crrev.com/49740e42977be69ae7c1af0f01df1758957c539b
Cr-Commit-Position: refs/heads/master@{#433019}
==========

to

==========
Revert of Add Store+Sync to reading list. (patchset #20 id:380001 of
https://codereview.chromium.org/2451843002/ )

Reason for revert:
Failing compile on ios-simulator-xcode-clang:

reading_list_store_unittest.cc:75:12: error: no viable conversion from returned
value of type 'unique_ptr<TestModelTypeChangeProcessor>' to function return type
'unique_ptr<syncer::ModelTypeChangeProcessor>'
    return processor;
           ^~~~~~~~~

It isn't legal to return a unique_ptr<B> from a function that returns
unique_ptr<A> even if A is a base class. You need to explicitly declare
|processor| to have type unique_ptr<syncer::ModelTypeChangeProcessor>.
I'm not sure why this wasn't picked up by the try bots.

Original issue's description:
> Add Store+Sync to reading list.
> 
> This CL creates a ModelTypeService for reading list.
> This service will store persistent data for the Reading list model and sync
> data between devices.
> 
> The previous store using NSUserDefaults will not be cleaned.
> As it was only accessible from canary behind an experimental flag, no user
> should be affected.
> 
> BUG=661668
> 
> Committed: https://crrev.com/faa080c524c6a80c2ac276359e29dec8cf7946c4
> Cr-Commit-Position: refs/heads/master@{#432845}

TBR=pavely@chromium.org,skym@chromium.org,jif@chromium.org,olivierrobin@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=661668

Committed:
https://chromium.googlesource.com/chromium/src/+/49740e42977be69ae7c1af0f01df...
==========

[Matt Giuca, 2016-11-18 02:02:56]

Committed patchset #1 (id:1) manually as
49740e42977be69ae7c1af0f01df1758957c539b (presubmit successful).

[Olivier, 2016-11-18 08:15:13]

LGTM.