Chromium Code Reviews
DescriptionReland of Don't reset scroll position of contents on every ScrollView layout. (patchset #1 id:1 of https://codereview.chromium.org/2509243002/ )
Reason for revert:
tapted@ disabled the failing test, which we suspect was only failing due to how this patch affected sharding
Original issue's description:
> Revert of Don't reset scroll position of contents on every ScrollView layout. (patchset #3 id:40001 of https://codereview.chromium.org/2509783002/ )
>
> Reason for revert:
> This change likely breaks NativeWidgetMacTest.WindowModalSheet test on Mac.
>
> https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/33145/steps/views_unittests%20on%20Mac-10.9/logs/NativeWidgetMacTest.WindowModalSheet
>
> Original issue's description:
> > Don't reset scroll position of contents on every ScrollView layout.
> >
> > Also do a little cleanup in ash scrollview related code.
> >
> > BUG=664930
> >
> > Committed: https://crrev.com/210e0fa83113f83d29ac3c1203c2047e905601e9
> > Cr-Commit-Position: refs/heads/master@{#432749}
>
> TBR=sky@chromium.org,estade@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664930
>
> Committed: https://crrev.com/cd3b2a6045f96ac2670e84b92c89acf5a3a99d75
> Cr-Commit-Position: refs/heads/master@{#432827}
TBR=sky@chromium.org,msramek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664930
Committed: https://crrev.com/cd1eb00936e36ec81baff590d17ccfa414aaa9a8
Cr-Commit-Position: refs/heads/master@{#433189}
Patch Set 1 #
Messages
Total messages: 15 (9 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||