Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2507053004: Reland of Don't reset scroll position of contents on every ScrollView layout. (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
msramek, tapted, sky
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Don't reset scroll position of contents on every ScrollView layout. (patchset #1 id:1 of https://codereview.chromium.org/2509243002/ ) Reason for revert: tapted@ disabled the failing test, which we suspect was only failing due to how this patch affected sharding Original issue's description: > Revert of Don't reset scroll position of contents on every ScrollView layout. (patchset #3 id:40001 of https://codereview.chromium.org/2509783002/ ) > > Reason for revert: > This change likely breaks NativeWidgetMacTest.WindowModalSheet test on Mac. > > https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/33145/steps/views_unittests%20on%20Mac-10.9/logs/NativeWidgetMacTest.WindowModalSheet > > Original issue's description: > > Don't reset scroll position of contents on every ScrollView layout. > > > > Also do a little cleanup in ash scrollview related code. > > > > BUG=664930 > > > > Committed: https://crrev.com/210e0fa83113f83d29ac3c1203c2047e905601e9 > > Cr-Commit-Position: refs/heads/master@{#432749} > > TBR=sky@chromium.org,estade@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=664930 > > Committed: https://crrev.com/cd3b2a6045f96ac2670e84b92c89acf5a3a99d75 > Cr-Commit-Position: refs/heads/master@{#432827} TBR=sky@chromium.org,msramek@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664930 Committed: https://crrev.com/cd1eb00936e36ec81baff590d17ccfa414aaa9a8 Cr-Commit-Position: refs/heads/master@{#433189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -11 lines) Patch
M ash/common/system/chromeos/bluetooth/tray_bluetooth.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/fixed_sized_scroll_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/tray/tray_details_view.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M ui/views/controls/scroll_view_unittest.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Evan Stade
Created Reland of Don't reset scroll position of contents on every ScrollView layout.
4 years, 1 month ago (2016-11-17 22:45:51 UTC) #1
Evan Stade
to be landed after https://codereview.chromium.org/2508153003/
4 years, 1 month ago (2016-11-17 22:46:42 UTC) #4
sky
I don't think you need it, but LGTM
4 years, 1 month ago (2016-11-18 00:47:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2507053004/1
4 years, 1 month ago (2016-11-18 14:20:09 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 14:21:00 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 14:22:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd1eb00936e36ec81baff590d17ccfa414aaa9a8
Cr-Commit-Position: refs/heads/master@{#433189}

Powered by Google App Engine
This is Rietveld 408576698