Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 250703003: CoreAnimation: Fix download shelf pattern phase (Closed)

Created:
6 years, 8 months ago by ccameron
Modified:
6 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

CoreAnimation: Fix download shelf pattern phase We should consider having cr_setPatternPhase make the call to cr_viewBeingDrawnTo, but that has some layering issues (base versus chrome), and fixing them would be merge-unfriendly. TBR=avi BUG=363750 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/cocoa/download/download_shelf_view.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 8 months ago (2014-04-24 22:01:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/250703003/1
6 years, 8 months ago (2014-04-24 22:06:48 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 23:07:20 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-24 23:07:20 UTC) #4
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 8 months ago (2014-04-25 20:03:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/250703003/1
6 years, 8 months ago (2014-04-25 21:46:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 23:29:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-25 23:29:40 UTC) #8
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 8 months ago (2014-04-25 23:36:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/250703003/1
6 years, 8 months ago (2014-04-25 23:40:28 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 10:05:21 UTC) #11
Message was sent while issue was closed. 
Change committed as 266347

Powered by Google App Engine
This is Rietveld 408576698