Move CPDF_DocRenderData from render_int

Move CPDF_DocRenderData from render_int

First CL in an attempt to reduce the class cluttering in
fpdf_render_text, fpdf_render_image, and fpdf_render.

Committed: https://pdfium.googlesource.com/pdfium/+/935c6310adacf2f4a4265e831e6cb60dc7a35803

[npm, 2016-11-17 17:14:21]

Description was changed from

==========
Move CPDF_DocRenderData from render_int

First CL in an attempt to reduce the class cluttering in
fpdf_render_text, fpdf_render_image, and fpdf_render.
==========

to

==========
Move CPDF_DocRenderData from render_int

First CL in an attempt to reduce the class cluttering in
fpdf_render_text, fpdf_render_image, and fpdf_render.
==========

[npm, 2016-11-17 17:14:21]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, tsepez@chromium.org

[npm, 2016-11-17 17:14:30]

ptal

[Tom Sepez, 2016-11-17 17:59:01]

Yay! LGTM

[dsinclair, 2016-11-17 18:02:35]

lgtm w/ nit.

https://codereview.chromium.org/2507023006/diff/1/core/fpdfapi/render/cpdf_do...
File core/fpdfapi/render/cpdf_docrenderdata.h (right):

https://codereview.chromium.org/2507023006/diff/1/core/fpdfapi/render/cpdf_do...
core/fpdfapi/render/cpdf_docrenderdata.h:24: ~CPDF_DocRenderData();
Blank line after.

https://codereview.chromium.org/2507023006/diff/1/core/fpdfapi/render/cpdf_do...
core/fpdfapi/render/cpdf_docrenderdata.h:28: void
ReleaseCachedType3(CPDF_Type3Font* pFont);
Can you put these with the Get methods they relate too?

https://codereview.chromium.org/2507023006/diff/1/core/fpdfapi/render/cpdf_do...
core/fpdfapi/render/cpdf_docrenderdata.h:37: CPDF_Document* m_pPDFDoc;
Is this un-owned? If so, can you add a // Not owned.

[npm, 2016-11-17 18:13:53]

https://codereview.chromium.org/2507023006/diff/1/core/fpdfapi/render/cpdf_do...
File core/fpdfapi/render/cpdf_docrenderdata.h (right):

https://codereview.chromium.org/2507023006/diff/1/core/fpdfapi/render/cpdf_do...
core/fpdfapi/render/cpdf_docrenderdata.h:24: ~CPDF_DocRenderData();
On 2016/11/17 18:02:35, dsinclair wrote:
> Blank line after.

Done.

https://codereview.chromium.org/2507023006/diff/1/core/fpdfapi/render/cpdf_do...
core/fpdfapi/render/cpdf_docrenderdata.h:28: void
ReleaseCachedType3(CPDF_Type3Font* pFont);
On 2016/11/17 18:02:35, dsinclair wrote:
> Can you put these with the Get methods they relate too?

Done.

https://codereview.chromium.org/2507023006/diff/1/core/fpdfapi/render/cpdf_do...
core/fpdfapi/render/cpdf_docrenderdata.h:37: CPDF_Document* m_pPDFDoc;
On 2016/11/17 18:02:35, dsinclair wrote:
> Is this un-owned? If so, can you add a // Not owned.

Done.

[npm, 2016-11-17 18:14:14]

The CQ bit was checked by npm@chromium.org

[npm, 2016-11-17 18:14:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2507023006/#ps20001
(title: "Comments")

[commit-bot: I haz the power, 2016-11-17 18:14:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 18:47:46]

Description was changed from

==========
Move CPDF_DocRenderData from render_int

First CL in an attempt to reduce the class cluttering in
fpdf_render_text, fpdf_render_image, and fpdf_render.
==========

to

==========
Move CPDF_DocRenderData from render_int

First CL in an attempt to reduce the class cluttering in
fpdf_render_text, fpdf_render_image, and fpdf_render.

Committed:
https://pdfium.googlesource.com/pdfium/+/935c6310adacf2f4a4265e831e6cb60dc7a3...
==========

[commit-bot: I haz the power, 2016-11-17 18:47:47]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/935c6310adacf2f4a4265e831e6cb60dc7a3...