Support script modify iframe scrolling, marginWidth and marginHeight attr

third_party/WebKit/Source/web/WebFrame.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "public/web/WebFrame.h"
 
 #include "bindings/core/v8/WindowProxyManager.h"
+#include "core/HTMLNames.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/RemoteFrame.h"
 #include "core/html/HTMLFrameElementBase.h"
 #include "core/html/HTMLFrameOwnerElement.h"
 #include "core/page/Page.h"
 #include "platform/UserGestureIndicator.h"
 #include "platform/heap/Handle.h"
 #include "public/web/WebElement.h"
 #include "public/web/WebFrameOwnerProperties.h"
 #include "public/web/WebSandboxFlags.h"
 #include "web/OpenedFrameTracker.h"
 #include "web/RemoteFrameOwner.h"
 #include "web/WebLocalFrameImpl.h"
 #include "web/WebRemoteFrameImpl.h"
+#include "wtf/Optional.h"
 #include <algorithm>
 
 namespace blink {
 
+using namespace HTMLNames;
+
 bool WebFrame::swap(WebFrame* frame) {
   using std::swap;
   Frame* oldFrame = toImplBase()->frame();
   if (oldFrame->isDetaching())
     return false;
 
   // Unload the current Document in this frame: this calls unload handlers,
   // detaches child frames, etc. Since this runs script, make sure this frame
   // wasn't detached before continuing with the swap.
   // FIXME: There is no unit test for this condition, so one needs to be
@@ skipping 93 matching lines @@
 WebInsecureRequestPolicy WebFrame::getInsecureRequestPolicy() const {
   return toImplBase()->frame()->securityContext()->getInsecureRequestPolicy();
 }
 
 void WebFrame::setFrameOwnerProperties(
     const WebFrameOwnerProperties& properties) {
   // At the moment, this is only used to replicate frame owner properties
   // for frames with a remote owner.
   RemoteFrameOwner* owner = toRemoteFrameOwner(toImplBase()->frame()->owner());
   DCHECK(owner);
-  owner->setScrollingMode(properties.scrollingMode);
-  owner->setMarginWidth(properties.marginWidth);
-  owner->setMarginHeight(properties.marginHeight);
+
+  Optional<int> marginWidth;
+  Optional<int> marginHeight;
+  bool scrollingModeChanged = false;
+
+  if (owner->scrollingMode() !=
+      static_cast<ScrollbarMode>(properties.scrollingMode)) {
+    owner->setScrollingMode(properties.scrollingMode);

[bokan, 2016/11/21 13:21:52]

There's no need to check for changes when setting FrameOwner's values, this was
fine as it was.

+    scrollingModeChanged = true;
+  }
+  if (owner->marginWidth() != properties.marginWidth) {
+    owner->setMarginWidth(properties.marginWidth);
+    marginWidth = properties.marginWidth;
+  }
+  if (owner->marginHeight() != properties.marginHeight) {
+    owner->setMarginHeight(properties.marginHeight);
+    marginHeight = properties.marginHeight;
+  }
   owner->setAllowFullscreen(properties.allowFullscreen);
   owner->setCsp(properties.requiredCsp);
   owner->setDelegatedpermissions(properties.delegatedPermissions);
+
+  Frame* frame = toImplBase()->frame();
+  DCHECK(frame);
+
+  if (frame->isLocalFrame()) {
+    LocalFrame* localFrame = toLocalFrame(frame);
+    if (localFrame->document()) {
+      localFrame->document()->didChangeFrameOwnerProperties(

[bokan, 2016/11/21 13:21:52]

If you move this up to before we set the values on RemoteFrameOwner, you can
just set the values from properties and didChangeFrameOwnerProperties can check
the value against the RemoteFrameOwner to see if they changed.

+          marginWidth, marginHeight, scrollingModeChanged);
+    }
+  }
 }
 
 WebFrame* WebFrame::opener() const {
   return m_opener;
 }
 
 void WebFrame::setOpener(WebFrame* opener) {
   if (m_opener)
     m_opener->m_openedFrameTracker->remove(this);
   if (opener)
@@ skipping 168 matching lines @@
   void WebFrame::clearWeakFrames(VisitorDispatcher visitor) {              \
     clearWeakFramesImpl(visitor);                                          \
   }
 
 DEFINE_VISITOR_METHOD(Visitor*)
 DEFINE_VISITOR_METHOD(InlinedGlobalMarkingVisitor)
 
 #undef DEFINE_VISITOR_METHOD
 
 }  // namespace blink