third_party/WebKit/LayoutTests/fast/frames/script-modify-iframe-attr.html - Issue 2507023002: Support script modify iframe scrolling, marginWidth and marginHeight attr

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/frames/script-modify-iframe-attr.html

Issue 2507023002: Support script modify iframe scrolling, marginWidth and marginHeight attr (Closed)

Patch Set: add fix for marginWidth and marginHeight Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <script>

	4 function modify_attr() {

	5 var ifr = document.getElementById('ifr');

	6 ifr.scrolling = 'no';

	7 ifr.marginWidth = '50';

	8 ifr.marginHeight = '100';

	9 testRunner.notifyDone();

	10 }

	11 </script>

	12

	13 <iframe id="ifr" onload="modify_attr();" scrolling="yes"
	bokan 2016/11/18 20:56:18 I believe this will fire when the iframe is loaded I believe this will fire when the iframe is loaded, but not necessarily when the parent frame is. I would prefer if we call this from the root document's onload, that only gets called when all the children are loaded I believe.
	14 style="width:200px;height:200px;"

	15 src="http://127.0.0.1:8000/fast/frames/resources/big-page.html">

	16 </iframe>

	17

	18 <script src="/resources/testharness.js"></script>

	19 <script src="/resources/testharnessreport.js"></script>
	bokan 2016/11/18 20:56:18 I don't think this test makes any use of testharne I don't think this test makes any use of testharness.
	20 <script>

	21 testRunner.waitUntilDone();

	22 </script>

OLD	NEW