third_party/WebKit/LayoutTests/http/tests/frames/script-modify-iframe-attr.html - Issue 2507023002: Support script modify iframe scrolling, marginWidth and marginHeight attr

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/frames/script-modify-iframe-attr.html

Issue 2507023002: Support script modify iframe scrolling, marginWidth and marginHeight attr (Closed)

Patch Set: add postMessage to test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <script>

	4 window.addEventListener("message", (event) => {

	5 var ifr = document.getElementById('ifr');

	6 ifr.scrolling = 'no';

	7 ifr.marginWidth = '50';

	8 ifr.marginHeight = '100';

	9 if (testRunner)

	10 testRunner.notifyDone();

	11 });

	12

	13 window.onload = () => {

	14 if (testRunner)

	15 testRunner.waitUntilDone();

	16 var ifr = document.getElementById('ifr');

	17 ifr.contentWindow.postMessage({}, '*');
	alexmos 2016/11/22 05:13:11 I think the scrolling/margin attributes should be I think the scrolling/margin attributes should be changed before sending this postMessage. I.e., the goal of the postMessage would be to guarantee that the OOPIF has seen and processed scrolling/margin updates (since the postMessage IPC would be processed after FrameMsg_SetFrameOwnerProperties). I think that should help to make this pass with --site-per-process once we fix https://bugs.chromium.org/p/chromium/issues/detail?id=667551.
	18 };

	19 </script>

	20

	21 <iframe id="ifr" scrolling="yes" style="width:200px;height:200px;"

	22 src="http://localhost:8000/frames/resources/subframe.html">

	23 </iframe>

OLD	NEW