third_party/WebKit/LayoutTests/fast/frames/script-modify-iframe-attr.html - Issue 2507023002: Support script modify iframe scrolling, marginWidth and marginHeight attr

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/frames/script-modify-iframe-attr.html

Issue 2507023002: Support script modify iframe scrolling, marginWidth and marginHeight attr (Closed)

Patch Set: bokan@ comment#19 addressed Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2

	3 <script>

	4 window.onload = () => {

	5 var ifr = document.getElementById('ifr');

	6 ifr.scrolling = 'no';

	7 ifr.marginWidth = '50';

	8 ifr.marginHeight = '100';

	9 };

	10 </script>

	11

	12 <iframe id="ifr" scrolling="yes" style="width:200px;height:200px;"

	13 src="http://127.0.0.1:8000/fast/frames/resources/big-page.html">
	alexmos 2016/11/21 17:56:56 Just to check: is this going to get OOPIF coverage Just to check: is this going to get OOPIF coverage? This is in fast/, so I think this will get served from a file: URL, and the iframe will still end up as an OOPIF if the test is run with --site-per-process. But can you verify? Another thing is that as of right now, only the "Site Isolation Win" FYI bot runs all layout tests with --site-per-process. Our other bots (including the linux_site_isolation trybot) only run the http/tests subset of layout tests. So ideally, to get coverage on those bots also, we'd switch this test to localhost:8000 and move the test over to http/tests. Is that possible/easy to do?
	14 </iframe>

OLD	NEW