Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4143)

Unified Diff: chrome/browser/resources/settings/on_startup_page/on_startup_page.js

Issue 2507003005: Implement extension controlled indicators, starting with New Tab page (Closed)
Patch Set: merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/on_startup_page/on_startup_page.js
diff --git a/chrome/browser/resources/settings/on_startup_page/on_startup_page.js b/chrome/browser/resources/settings/on_startup_page/on_startup_page.js
index bdce9f05365f12de048cab2c3e8f270e163c714a..313c41530de433cfff1c69a32a4d2e9d63e277de 100644
--- a/chrome/browser/resources/settings/on_startup_page/on_startup_page.js
+++ b/chrome/browser/resources/settings/on_startup_page/on_startup_page.js
@@ -18,14 +18,14 @@ Polymer({
is: 'settings-on-startup-page',
properties: {
- /**
- * Preferences state.
- */
prefs: {
type: Object,
notify: true,
},
+ /** @private {?NtpExtension} */
+ ntpExtension_: Object,
+
/**
* Enum values for the 'session.restore_on_startup' preference.
* @private {!Object<string, number>}
@@ -34,13 +34,36 @@ Polymer({
readOnly: true,
type: Object,
value: {
- OPEN_NEW_TAB: 5,
CONTINUE: 1,
+ OPEN_NEW_TAB: 5,
OPEN_SPECIFIC: 4,
},
},
},
+ /** @override */
+ attached: function() {
+ this.getNtpExtension_();
+ },
+
+ /** @private */
+ getNtpExtension_: function() {
+ settings.OnStartupBrowserProxyImpl.getInstance().getNtpExtension().then(
+ function(ntpExtension) {
+ this.ntpExtension_ = ntpExtension;
+ }.bind(this));
+ },
+
+ /**
+ * @param {?NtpExtension} ntpExtension
+ * @param {number} restoreOnStartup Value of prefs.session.restore_on_startup.
+ * @return {boolean}
+ * @private
+ */
+ showIndicator_: function(ntpExtension, restoreOnStartup) {
+ return !!ntpExtension && restoreOnStartup == this.prefValues_.OPEN_NEW_TAB;
+ },
+
/**
* Determine whether to show the user defined startup pages.
* @param {number} restoreOnStartup Enum value from prefValues_.

Powered by Google App Engine
This is Rietveld 408576698