Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: chrome/browser/resources/settings/controls/extension_controlled_indicator.js

Issue 2507003005: Implement extension controlled indicators, starting with New Tab page (Closed)
Patch Set: mo hackin' Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/controls/extension_controlled_indicator.js
diff --git a/chrome/browser/resources/settings/controls/extension_controlled_indicator.js b/chrome/browser/resources/settings/controls/extension_controlled_indicator.js
new file mode 100644
index 0000000000000000000000000000000000000000..796d179546d6cd50c368d200bea8a747fa8b9004
--- /dev/null
+++ b/chrome/browser/resources/settings/controls/extension_controlled_indicator.js
@@ -0,0 +1,36 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
dpapad 2016/11/17 01:50:07 2016
Dan Beam 2016/11/17 02:50:14 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+Polymer({
+ is: 'extension-controlled-indicator',
+
+ behaviors: [I18nBehavior],
+
+ properties: {
+ extensionCanBeDisabled: Boolean,
+ extensionId: String,
+ extensionName: String,
+ },
+
+ /**
+ * @param {string} extensionId
+ * @param {string} extensionName
+ * @return {string}
+ * @private
+ */
+ getLabel_: function(extensionId, extensionName) {
+ var manageUrl = 'chrome://extensions/?id=' + assert(this.extensionId);
+ return this.i18n('controlledByExtension',
+ `<a href="${manageUrl}" target="_blank">` +
+ assert(this.extensionName) + '</a>');
+ },
+
+ /** @private */
+ onDisableTap_: function() {
+ assert(this.extensionCanBeDisabled);
dpapad 2016/11/17 01:50:07 Can you verify that C++ is also checking for this
Dan Beam 2016/11/17 02:50:14 https://cs.chromium.org/chromium/src/chrome/browse
+ settings.ExtensionControlBrowserProxyImpl.getInstance().disableExtension(
+ assert(this.extensionId));
+ this.fire('extension-disable');
+ },
+});

Powered by Google App Engine
This is Rietveld 408576698