Enable security state computation for HeadlessWebContents.

Enable security state computation for HeadlessWebContents.

BUG=609394
Committed: https://crrev.com/f2531a56666efc359de43e0c8f3230868b2d5698
Cr-Commit-Position: refs/heads/master@{#432948}

[Eric Seckler, 2016-11-16 11:05:08]

The CQ bit was checked by eseckler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 11:05:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 11:09:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 11:09:52]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eric Seckler, 2016-11-16 11:27:18]

Patchset #1 (id:1) has been deleted

[Eric Seckler, 2016-11-16 12:26:14]

Patchset #1 (id:20001) has been deleted

[Eric Seckler, 2016-11-16 12:27:26]

eseckler@chromium.org changed reviewers:
+ alexclarke@chromium.org, estark@chromium.org, sky@chromium.org

[Eric Seckler, 2016-11-16 12:27:27]

Alex, PTAL.

estark@ and sky@: need a quick lgtm for changes to headless/lib/browser/DEPS.
(sky@: It's only a formatting change, but it still seems I need a new lgtm for
ui/aura :))

Thanks!

[alex clarke (OOO till 29th), 2016-11-16 13:57:38]

lgtm

[sky, 2016-11-16 16:56:10]

Don't you need an owner for the new dep on components/security_state?

[Eric Seckler, 2016-11-16 17:01:26]

On 2016/11/16 16:56:10, sky wrote:
> Don't you need an owner for the new dep on components/security_state?

Yup, that's estark's job :)

I added you for the "," behind ui/aura .. to make the presubmit happy :)

Thanks!

[estark, 2016-11-17 08:44:27]

lgtm

https://codereview.chromium.org/2507003002/diff/40001/headless/lib/headless_w...
File headless/lib/headless_web_contents_browsertest.cc (right):

https://codereview.chromium.org/2507003002/diff/40001/headless/lib/headless_w...
headless/lib/headless_web_contents_browsertest.cc:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
Did we go back to 2015? That would be great, 2016 sucks

[Eric Seckler, 2016-11-17 08:50:57]

https://codereview.chromium.org/2507003002/diff/40001/headless/lib/headless_w...
File headless/lib/headless_web_contents_browsertest.cc (right):

https://codereview.chromium.org/2507003002/diff/40001/headless/lib/headless_w...
headless/lib/headless_web_contents_browsertest.cc:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
On 2016/11/17 08:44:27, estark (slow thru Nov 18) wrote:
> Did we go back to 2015? That would be great, 2016 sucks

Ha! Good spot, no idea how that happened :)

[Eric Seckler, 2016-11-17 08:53:31]

sky@, please rubber-stamp :) Thanks!

** Presubmit ERRORS **
You need LGTM from owners of depends-on paths in DEPS that were modified in this
CL:
    '+ui/aura',

[sky, 2016-11-17 18:05:31]

LGTM

[Eric Seckler, 2016-11-17 18:52:28]

The CQ bit was checked by eseckler@chromium.org

[Eric Seckler, 2016-11-17 18:52:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
alexclarke@chromium.org, estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2507003002/#ps60001
(title: "fix copyright")

[commit-bot: I haz the power, 2016-11-17 18:53:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 20:21:24]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-11-17 20:29:34]

Description was changed from

==========
Enable security state computation for HeadlessWebContents.

BUG=609394
==========

to

==========
Enable security state computation for HeadlessWebContents.

BUG=609394

Committed: https://crrev.com/f2531a56666efc359de43e0c8f3230868b2d5698
Cr-Commit-Position: refs/heads/master@{#432948}
==========

[commit-bot: I haz the power, 2016-11-17 20:29:35]

Patchset 2 (id:??) landed as
https://crrev.com/f2531a56666efc359de43e0c8f3230868b2d5698
Cr-Commit-Position: refs/heads/master@{#432948}