Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2506973003: [sensors](CrOS/Linux) Fix: create sensors when no scaling file is specified (Closed)

Created:
4 years, 1 month ago by maksims (do not use this acc)
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sensors](CrOS/Linux) Fix: create sensors when no scaling file is specified A fix to a bug, which allows to create sensor readers, when no scaling files are passed to be found BUG=661478 Committed: https://crrev.com/ac746389052ab446ed3514a33aaf08955b4dbf77 Cr-Commit-Position: refs/heads/master@{#432816}

Patch Set 1 #

Patch Set 2 : check if directory #

Patch Set 3 : use the first version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M device/generic_sensor/linux/platform_sensor_utils_linux.cc View 1 2 2 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
maksims (do not use this acc)
please take a look
4 years, 1 month ago (2016-11-16 13:21:42 UTC) #3
maksims (do not use this acc)
take another look
4 years, 1 month ago (2016-11-16 13:50:06 UTC) #5
Mikhail
lgtm
4 years, 1 month ago (2016-11-16 14:04:57 UTC) #8
Reilly Grant (use Gerrit)
lgtm
4 years, 1 month ago (2016-11-16 16:56:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506973003/40001
4 years, 1 month ago (2016-11-17 08:44:54 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-17 08:50:46 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 08:52:39 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ac746389052ab446ed3514a33aaf08955b4dbf77
Cr-Commit-Position: refs/heads/master@{#432816}

Powered by Google App Engine
This is Rietveld 408576698