Chromium Code Reviews
DescriptionRevert of Fix bug where removed (but not deleted) windows are not reflected in the tree properly (patchset #2 id:20001 of https://codereview.chromium.org/2495533005/ )
Reason for revert:
SystemTrayTest.NullDefaultViewIsNotRecorded failing (https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/60026)
Original issue's description:
> Fix bug where removed (but not deleted) windows are not reflected in the tree properly
>
> When there are windows which are removed as children of some parent, and
> they still exist, OnWindowDestroying is not called because the child window
> was never destroyed. However, OnWindowTreeChanging is called, if
> the target has an old_parent, aka the parent it is being removed from.
> OnWindowTreeChanged is called if the target has a new_parent, aka the
> parent it is being added to.
>
> This CL removes nodes on OnWindowTreeChanging and adds them back in
> OnWindowTreeChanged if necessary. Since we only want them to trigger once,
> we check to see in either callback if the window that the callback is
> being called on is the old_parent or the new_parent.
>
> BUG=648701
>
> Committed: https://crrev.com/f555669c992a0bf22b8994d6a6f5a3f27e9f32c4
> Cr-Commit-Position: refs/heads/master@{#432366}
TBR=sadrul@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=648701
Committed: https://crrev.com/e75795096a81f406c92afce687ef4aa54900845f
Cr-Commit-Position: refs/heads/master@{#432374}
Patch Set 1 #
Messages
Total messages: 15 (8 generated)
|
|||||||||||||||||||||||||||||||||||||