Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2506913002: Revert of Fix bug where removed (but not deleted) windows are not reflected in the tree properly (Closed)

Created:
4 years, 1 month ago by Sarmad Hashmi
Modified:
4 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, sadrul, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix bug where removed (but not deleted) windows are not reflected in the tree properly (patchset #2 id:20001 of https://codereview.chromium.org/2495533005/ ) Reason for revert: SystemTrayTest.NullDefaultViewIsNotRecorded failing (https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/60026) Original issue's description: > Fix bug where removed (but not deleted) windows are not reflected in the tree properly > > When there are windows which are removed as children of some parent, and > they still exist, OnWindowDestroying is not called because the child window > was never destroyed. However, OnWindowTreeChanging is called, if > the target has an old_parent, aka the parent it is being removed from. > OnWindowTreeChanged is called if the target has a new_parent, aka the > parent it is being added to. > > This CL removes nodes on OnWindowTreeChanging and adds them back in > OnWindowTreeChanged if necessary. Since we only want them to trigger once, > we check to see in either callback if the window that the callback is > being called on is the old_parent or the new_parent. > > BUG=648701 > > Committed: https://crrev.com/f555669c992a0bf22b8994d6a6f5a3f27e9f32c4 > Cr-Commit-Position: refs/heads/master@{#432366} TBR=sadrul@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=648701 Committed: https://crrev.com/e75795096a81f406c92afce687ef4aa54900845f Cr-Commit-Position: refs/heads/master@{#432374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -61 lines) Patch
M ash/common/devtools/ash_devtools_dom_agent.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/common/devtools/ash_devtools_dom_agent.cc View 3 chunks +19 lines, -28 lines 0 comments Download
M ash/common/devtools/ash_devtools_unittest.cc View 2 chunks +1 line, -30 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Sarmad Hashmi
Created Revert of Fix bug where removed (but not deleted) windows are not reflected in ...
4 years, 1 month ago (2016-11-16 04:23:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506913002/1
4 years, 1 month ago (2016-11-16 04:24:22 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-16 04:24:23 UTC) #5
sadrul
lgtm
4 years, 1 month ago (2016-11-16 04:42:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506913002/1
4 years, 1 month ago (2016-11-16 04:43:28 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 04:47:34 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 04:49:35 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e75795096a81f406c92afce687ef4aa54900845f
Cr-Commit-Position: refs/heads/master@{#432374}

Powered by Google App Engine
This is Rietveld 408576698