[sensors] Gyroscope sensor bindings implementation

[sensors] Gyroscope sensor bindings implementation

This CL implements blink bindings for Gyroscope sensor [1].
Layout tests are also added.

Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_IReUkNKF6o
[1] ED specification for Gyroscope https://w3c.github.io/gyroscope/

BUG=661478
Committed: https://crrev.com/3d1bd0e6727ee92cc13fda7ca74055f5d8b49e5c
Cr-Commit-Position: refs/heads/master@{#432894}

[Mikhail, 2016-11-16 11:37:43]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 11:38:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-11-16 13:31:41]

Description was changed from

==========
[sensors] Gyroscope sensor bindings implementation

This CL implements blink bindings for Gyroscope sensor [1].
Layout tests are also added.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_IReUkNKF6o
[1] ED specification for Gyroscope https://w3c.github.io/gyroscope/

BUG=661478
==========

to

==========
[sensors] Gyroscope sensor bindings implementation

This CL implements blink bindings for Gyroscope sensor [1].
Layout tests are also added.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_IReUkNKF6o
[1] ED specification for Gyroscope https://w3c.github.io/gyroscope/

BUG=661478
==========

[Mikhail, 2016-11-16 13:31:42]

mikhail.pozdnyakov@intel.com changed reviewers:
+ alexander.shalamov@intel.com, haraken@chromium.org, reillyg@chromium.org,
timvolodine@chromium.org

[Mikhail, 2016-11-16 13:31:53]

PTAL

[commit-bot: I haz the power, 2016-11-16 14:00:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 14:00:47]

Dry run: This issue passed the CQ dry run.

[shalamov, 2016-11-16 14:38:10]

On 2016/11/16 13:31:53, Mikhail wrote:
> PTAL

third_party/WebKit/Source/modules/sensor/* lgtm with nits

[shalamov, 2016-11-16 14:38:21]

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/sensor/Gyroscope.cpp (right):

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/Gyroscope.cpp:7: #include
"bindings/core/v8/ScriptPromise.h"
nit: ScriptPromise.h and ScriptPromiseResolver.h are not used

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/sensor/GyroscopeReading.cpp (right):

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/GyroscopeReading.cpp:7: #include
"modules/sensor/SensorProxy.h"
nit: not used

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/sensor/GyroscopeReading.h (right):

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/GyroscopeReading.h:8: #include
"modules/sensor/GyroscopeReadingInit.h"
nit: can be forward declared

[Reilly Grant (use Gerrit), 2016-11-16 18:50:51]

lgtm

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/sensor/Gyroscope.cpp (right):

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/Gyroscope.cpp:38: new
SensorReadingFactoryImpl<GyroscopeReading>());
As haraken@ suggested on the other review, use makeUnique.

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/sensor/GyroscopeReading.cpp (right):

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/GyroscopeReading.cpp:49:
previous.values[2] != z());
nit: parenthesis unnecessary

[haraken, 2016-11-17 06:05:09]

LGTM

[Mikhail, 2016-11-17 11:31:47]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 11:32:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 11:43:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 11:43:03]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)

[Mikhail, 2016-11-17 12:28:19]

Patchset #2 (id:20001) has been deleted

[Mikhail, 2016-11-17 13:34:17]

The CQ bit was checked by mikhail.pozdnyakov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 13:34:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mikhail, 2016-11-17 13:47:47]

Thanks for your comments!

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/sensor/Gyroscope.cpp (right):

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/Gyroscope.cpp:7: #include
"bindings/core/v8/ScriptPromise.h"
On 2016/11/16 14:38:20, shalamov wrote:
> nit: ScriptPromise.h and ScriptPromiseResolver.h are not used

Done.

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/Gyroscope.cpp:38: new
SensorReadingFactoryImpl<GyroscopeReading>());
On 2016/11/16 18:50:51, Reilly Grant wrote:
> As haraken@ suggested on the other review, use makeUnique.

Done.

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/sensor/GyroscopeReading.cpp (right):

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/GyroscopeReading.cpp:7: #include
"modules/sensor/SensorProxy.h"
On 2016/11/16 14:38:20, shalamov wrote:
> nit: not used

Done.

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/GyroscopeReading.cpp:49:
previous.values[2] != z());
On 2016/11/16 18:50:51, Reilly Grant wrote:
> nit: parenthesis unnecessary

Done.

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/sensor/GyroscopeReading.h (right):

https://codereview.chromium.org/2506903003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/sensor/GyroscopeReading.h:8: #include
"modules/sensor/GyroscopeReadingInit.h"
On 2016/11/16 14:38:20, shalamov wrote:
> nit: can be forward declared

Done.

[commit-bot: I haz the power, 2016-11-17 15:03:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 15:03:18]

Dry run: This issue passed the CQ dry run.

[Mikhail, 2016-11-17 16:40:15]

The CQ bit was checked by mikhail.pozdnyakov@intel.com

[Mikhail, 2016-11-17 16:40:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, reillyg@chromium.org, alexander.shalamov@intel.com
Link to the patchset: https://codereview.chromium.org/2506903003/#ps40001
(title: "Comments + rebase")

[commit-bot: I haz the power, 2016-11-17 16:40:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 16:46:28]

Description was changed from

==========
[sensors] Gyroscope sensor bindings implementation

This CL implements blink bindings for Gyroscope sensor [1].
Layout tests are also added.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_IReUkNKF6o
[1] ED specification for Gyroscope https://w3c.github.io/gyroscope/

BUG=661478
==========

to

==========
[sensors] Gyroscope sensor bindings implementation

This CL implements blink bindings for Gyroscope sensor [1].
Layout tests are also added.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_IReUkNKF6o
[1] ED specification for Gyroscope https://w3c.github.io/gyroscope/

BUG=661478
==========

[commit-bot: I haz the power, 2016-11-17 16:46:29]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-17 16:48:15]

Description was changed from

==========
[sensors] Gyroscope sensor bindings implementation

This CL implements blink bindings for Gyroscope sensor [1].
Layout tests are also added.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_IReUkNKF6o
[1] ED specification for Gyroscope https://w3c.github.io/gyroscope/

BUG=661478
==========

to

==========
[sensors] Gyroscope sensor bindings implementation

This CL implements blink bindings for Gyroscope sensor [1].
Layout tests are also added.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_IReUkNKF6o
[1] ED specification for Gyroscope https://w3c.github.io/gyroscope/

BUG=661478

Committed: https://crrev.com/3d1bd0e6727ee92cc13fda7ca74055f5d8b49e5c
Cr-Commit-Position: refs/heads/master@{#432894}
==========

[commit-bot: I haz the power, 2016-11-17 16:48:16]

Patchset 2 (id:??) landed as
https://crrev.com/3d1bd0e6727ee92cc13fda7ca74055f5d8b49e5c
Cr-Commit-Position: refs/heads/master@{#432894}