Fix double-deletion of VR Shell when exiting webVR in onPause.

Fix double-deletion of VR Shell when exiting webVR in onPause.

BUG=389343
Committed: https://crrev.com/3d430f6ccbef74cf7a96fc0b0a4b0da226d9f01c
Cr-Commit-Position: refs/heads/master@{#432900}

[mthiesse, 2016-11-16 00:54:35]

Description was changed from

==========
Fix double-deletion of VR Shell when exiting webVR in onPause.

BUG=
==========

to

==========
Fix double-deletion of VR Shell when exiting webVR in onPause.

BUG=389343
==========

[mthiesse, 2016-11-16 00:54:46]

mthiesse@chromium.org changed reviewers:
+ bajones@chromium.org

[mthiesse, 2016-11-16 00:54:46]

PTAL

[mthiesse, 2016-11-16 01:10:27]

Removed ExitWebVRIfNecessary entirely, because vr_shell.cc already calls
GvrDeviceProvider::OnGvrDelegateRemoved(); in its destructor.

[bajones, 2016-11-16 01:28:17]

On 2016/11/16 01:10:27, mthiesse wrote:
> Removed ExitWebVRIfNecessary entirely, because vr_shell.cc already calls
> GvrDeviceProvider::OnGvrDelegateRemoved(); in its destructor.

LGTM

[mthiesse, 2016-11-16 15:04:21]

mthiesse@chromium.org changed reviewers:
+ dtrainor@chromium.org

[mthiesse, 2016-11-16 15:04:21]

dtrainor@chromium.org: Please OWNERS review java changes.

[David Trainor- moved to gerrit, 2016-11-17 00:39:48]

java lgtm

[mthiesse, 2016-11-17 01:09:37]

The CQ bit was checked by mthiesse@chromium.org

[commit-bot: I haz the power, 2016-11-17 01:11:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 02:42:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 02:42:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mthiesse, 2016-11-17 02:47:10]

mthiesse@chromium.org changed reviewers:
+ bshe@chromium.org

[mthiesse, 2016-11-17 02:47:11]

bshe@chromium.org: PTAL

[bshe, 2016-11-17 02:47:22]

On 2016/11/17 02:42:33, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

rubber stamp lgtm

[mthiesse, 2016-11-17 02:48:52]

The CQ bit was checked by mthiesse@chromium.org

[commit-bot: I haz the power, 2016-11-17 02:50:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 03:15:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 03:15:29]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_compile_dbg on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_cronet on master.tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)

[mthiesse, 2016-11-17 03:16:50]

The CQ bit was checked by mthiesse@chromium.org

[commit-bot: I haz the power, 2016-11-17 03:18:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 04:04:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 04:04:08]

Failed to apply patch for
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:
While running git apply --index -p1;
  error: patch failed:
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:239
  error:
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:
patch does not apply

Patch:      
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
Index:
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
diff --git
a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
index
6ce254485561d69df4741de6dadc23831af663dc..ec4a766cf84c8b07606770952c6fabe49b9abf19
100644
---
a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
+++
b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
@@ -239,8 +239,6 @@ public class VrShellDelegate {
      */
     public boolean exitVRIfNecessary() {
         if (!mInVr) return false;
-        // If WebVR is presenting instruct it to exit.
-        nativeExitWebVRIfNecessary(mNativeVrShellDelegate);
         shutdownVR();
         return true;
     }
@@ -464,5 +462,4 @@ public class VrShellDelegate {
     }
 
     private native long nativeInit();
-    private native void nativeExitWebVRIfNecessary(long nativeVrShellDelegate);
 }

[mthiesse, 2016-11-17 15:06:17]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2016-11-17 15:06:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, bajones@chromium.org, bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2506853002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-17 15:06:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 17:43:23]

Description was changed from

==========
Fix double-deletion of VR Shell when exiting webVR in onPause.

BUG=389343
==========

to

==========
Fix double-deletion of VR Shell when exiting webVR in onPause.

BUG=389343
==========

[commit-bot: I haz the power, 2016-11-17 17:43:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 18:08:40]

Description was changed from

==========
Fix double-deletion of VR Shell when exiting webVR in onPause.

BUG=389343
==========

to

==========
Fix double-deletion of VR Shell when exiting webVR in onPause.

BUG=389343

Committed: https://crrev.com/3d430f6ccbef74cf7a96fc0b0a4b0da226d9f01c
Cr-Commit-Position: refs/heads/master@{#432900}
==========

[commit-bot: I haz the power, 2016-11-17 18:08:42]

Patchset 3 (id:??) landed as
https://crrev.com/3d430f6ccbef74cf7a96fc0b0a4b0da226d9f01c
Cr-Commit-Position: refs/heads/master@{#432900}