Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 250683002: Refactor cronet library loader. Move java LibraryLoader into cronet.jar. (Closed)

Created:
6 years, 8 months ago by mef
Modified:
6 years, 7 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Refactor Cronet library loader. Move java LibraryLoader into cronet.jar. BUG=354143 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -66 lines) Patch
M components/cronet.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A components/cronet/android/cronet_jni.cc View 1 chunk +55 lines, -0 lines 0 comments Download
A + components/cronet/android/java/src/org/chromium/net/LibraryLoader.java View 1 chunk +1 line, -1 line 0 comments Download
A components/cronet/android/org_chromium_net_UrlRequestContext.h View 1 chunk +16 lines, -0 lines 0 comments Download
M components/cronet/android/org_chromium_net_UrlRequestContext.cc View 3 chunks +6 lines, -41 lines 0 comments Download
M components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java View 1 chunk +1 line, -0 lines 0 comments Download
D components/cronet/android/sample/src/org/chromium/cronet_sample_apk/LibraryLoader.java View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mef
6 years, 8 months ago (2014-04-25 17:11:23 UTC) #1
mmenke
LGTM, nice cleanup!
6 years, 8 months ago (2014-04-25 18:46:36 UTC) #2
mef
The CQ bit was checked by mef@chromium.org
6 years, 8 months ago (2014-04-25 19:22:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/250683002/1
6 years, 8 months ago (2014-04-25 22:10:35 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 10:23:33 UTC) #5
Message was sent while issue was closed.
Change committed as 266357

Powered by Google App Engine
This is Rietveld 408576698