MD Settings: Fix Back navigation from section route to BASIC route.

MD Settings: Fix Back navigation from section route to BASIC route.

Currently, there is this problem:

1. Open MD Settings.
2. Open left menu and click on a section route.
3. Observe that the window has scrolled to the section.
4. Click the browser Back button.
5. Observe that the window remains scrolled to the section.

This CL fixes that bug and adds a test.

BUG=664070
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7e0c0949788eca92a82112f1a2786f910f68de8b
Cr-Commit-Position: refs/heads/master@{#432549}

[tommycli, 2016-11-15 23:51:34]

Description was changed from

==========
MD Settings: Fix Back navigation from section route to BASIC route.

Currently, there is this problem:

1. Open MD Settings.
2. Open left menu and click on a section route.
3. Observe that the window has scrolled to the section.
4. Click the browser Back button.
5. Observe that the window remains scrolled to the section.

This CL fixes that bug and adds a test.

BUG=664070
==========

to

==========
MD Settings: Fix Back navigation from section route to BASIC route.

Currently, there is this problem:

1. Open MD Settings.
2. Open left menu and click on a section route.
3. Observe that the window has scrolled to the section.
4. Click the browser Back button.
5. Observe that the window remains scrolled to the section.

This CL fixes that bug and adds a test.

BUG=664070
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-11-15 23:51:48]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 23:52:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-11-15 23:53:53]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 23:54:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 00:22:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 00:22:41]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[tommycli, 2016-11-16 02:25:23]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2016-11-16 02:25:24]

Dbeam: PTAL thanks!

[Dan Beam, 2016-11-16 02:32:02]

https://codereview.chromium.org/2506793002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/main_page_behavior.js
(right):

https://codereview.chromium.org/2506793002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:35:
this.scroller.scrollTop = 0;
do we still want to execute the code that follows this?

[tommycli, 2016-11-16 16:38:39]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[tommycli, 2016-11-16 16:39:02]

dbeam: thanks!

https://codereview.chromium.org/2506793002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/main_page_behavior.js
(right):

https://codereview.chromium.org/2506793002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:35:
this.scroller.scrollTop = 0;
On 2016/11/16 02:32:01, Dan Beam wrote:
> do we still want to execute the code that follows this?

Done. Indeed it does seem that the rest of the code is not necessary in this
case.

[commit-bot: I haz the power, 2016-11-16 16:39:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-11-16 17:09:46]

lgtm

[tommycli, 2016-11-16 17:24:22]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2016-11-16 17:24:23]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-11-16 17:24:26]

thanks!

[commit-bot: I haz the power, 2016-11-16 17:24:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 17:59:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-16 18:20:04]

Description was changed from

==========
MD Settings: Fix Back navigation from section route to BASIC route.

Currently, there is this problem:

1. Open MD Settings.
2. Open left menu and click on a section route.
3. Observe that the window has scrolled to the section.
4. Click the browser Back button.
5. Observe that the window remains scrolled to the section.

This CL fixes that bug and adds a test.

BUG=664070
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix Back navigation from section route to BASIC route.

Currently, there is this problem:

1. Open MD Settings.
2. Open left menu and click on a section route.
3. Observe that the window has scrolled to the section.
4. Click the browser Back button.
5. Observe that the window remains scrolled to the section.

This CL fixes that bug and adds a test.

BUG=664070
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7e0c0949788eca92a82112f1a2786f910f68de8b
Cr-Commit-Position: refs/heads/master@{#432549}
==========

[commit-bot: I haz the power, 2016-11-16 18:20:05]

Patchset 3 (id:??) landed as
https://crrev.com/7e0c0949788eca92a82112f1a2786f910f68de8b
Cr-Commit-Position: refs/heads/master@{#432549}