Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: content/browser/indexed_db/indexed_db_backing_store.h

Issue 2506773002: [IndexedDB] Integrating failures and corruption with transaction (Closed)
Patch Set: removed extra log statements Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/indexed_db/indexed_db_backing_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/indexed_db/indexed_db_backing_store.h
diff --git a/content/browser/indexed_db/indexed_db_backing_store.h b/content/browser/indexed_db/indexed_db_backing_store.h
index 48c46c060a960a367c1028e0ef568b0a9c83d78a..00d6678f6df333b87daeb6b430f7466b5d0740c3 100644
--- a/content/browser/indexed_db/indexed_db_backing_store.h
+++ b/content/browser/indexed_db/indexed_db_backing_store.h
@@ -349,18 +349,20 @@ class CONTENT_EXPORT IndexedDBBackingStore
IndexedDBBackingStore::RecordIdentifier record_identifier_;
private:
+ enum class ContinueResult { LEVELDB_ERROR, DONE, OUT_OF_BOUNDS };
+
// For cursors with direction Next or NextNoDuplicate.
- bool ContinueNext(const IndexedDBKey* key,
- const IndexedDBKey* primary_key,
- IteratorState state,
- leveldb::Status*);
+ ContinueResult ContinueNext(const IndexedDBKey* key,
+ const IndexedDBKey* primary_key,
+ IteratorState state,
+ leveldb::Status*);
// For cursors with direction Prev or PrevNoDuplicate. The PrevNoDuplicate
// case has additional complexity of not being symmetric with
// NextNoDuplicate.
- bool ContinuePrevious(const IndexedDBKey* key,
- const IndexedDBKey* primary_key,
- IteratorState state,
- leveldb::Status*);
+ ContinueResult ContinuePrevious(const IndexedDBKey* key,
+ const IndexedDBKey* primary_key,
+ IteratorState state,
+ leveldb::Status*);
DISALLOW_COPY_AND_ASSIGN(Cursor);
};
@@ -416,7 +418,7 @@ class CONTENT_EXPORT IndexedDBBackingStore
virtual leveldb::Status CreateIDBDatabaseMetaData(const base::string16& name,
int64_t version,
int64_t* row_id);
- virtual bool UpdateIDBDatabaseIntVersion(
+ virtual void UpdateIDBDatabaseIntVersion(
IndexedDBBackingStore::Transaction* transaction,
int64_t row_id,
int64_t version);
« no previous file with comments | « no previous file | content/browser/indexed_db/indexed_db_backing_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698