[IndexedDB] Integrating failures and corruption with transaction

content/browser/indexed_db/indexed_db_backing_store.h

Index: content/browser/indexed_db/indexed_db_backing_store.h
diff --git a/content/browser/indexed_db/indexed_db_backing_store.h b/content/browser/indexed_db/indexed_db_backing_store.h
index 48c46c060a960a367c1028e0ef568b0a9c83d78a..3bde197138bd124c1d522f99fee4b2eff7a56f99 100644
--- a/content/browser/indexed_db/indexed_db_backing_store.h
+++ b/content/browser/indexed_db/indexed_db_backing_store.h
@@ -318,6 +318,7 @@ class CONTENT_EXPORT IndexedDBBackingStore
                   IteratorState state,
                   leveldb::Status*);
     bool Advance(uint32_t count, leveldb::Status*);
+    // Returns true when no error and we haven't reached the end of the data.
     bool FirstSeek(leveldb::Status*);
 
     virtual std::unique_ptr<Cursor> Clone() const = 0;
@@ -350,6 +351,7 @@ class CONTENT_EXPORT IndexedDBBackingStore
 
    private:
     // For cursors with direction Next or NextNoDuplicate.
+    // Returns true when no error and we haven't reached the end of the data.

[cmumford, 2016/11/21 18:29:22]

Do you think it would be clearer if this instead returned an enumeration? Maybe
something like: ERROR, SUCCESS, LAST_KEY (names are crappy, but you get the
idea).

[dmurph, 2016/11/22 23:33:10]

mmmm this is a large change, as I'll want to change all of the Advance/Continue
calls above. Effects lots of files. I'll change the private ones here only for
now.

[cmumford, 2016/11/28 20:48:25]

Acknowledged.

     bool ContinueNext(const IndexedDBKey* key,
                       const IndexedDBKey* primary_key,
                       IteratorState state,
@@ -357,6 +359,7 @@ class CONTENT_EXPORT IndexedDBBackingStore
     // For cursors with direction Prev or PrevNoDuplicate. The PrevNoDuplicate
     // case has additional complexity of not being symmetric with
     // NextNoDuplicate.
+    // Returns true when no error and we haven't reached the end of the data.
     bool ContinuePrevious(const IndexedDBKey* key,
                           const IndexedDBKey* primary_key,
                           IteratorState state,
@@ -416,7 +419,7 @@ class CONTENT_EXPORT IndexedDBBackingStore
   virtual leveldb::Status CreateIDBDatabaseMetaData(const base::string16& name,
                                                     int64_t version,
                                                     int64_t* row_id);
-  virtual bool UpdateIDBDatabaseIntVersion(
+  virtual void UpdateIDBDatabaseIntVersion(
       IndexedDBBackingStore::Transaction* transaction,
       int64_t row_id,
       int64_t version);