Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2506753002: When analyzing a Bazel/Blaze workspace in which no build has been run, assume Bazel. (Closed)

Created:
4 years, 1 month ago by Paul Berry
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

When analyzing a Bazel/Blaze workspace in which no build has been run, assume Bazel. Previously we were returning `null`, causing all package resolution to fail. R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c6ad6fa114421ada6e89968c5b5d5832b30e32cd

Patch Set 1 #

Patch Set 2 : Rework using a static const. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M pkg/analyzer/lib/src/generated/bazel.dart View 1 3 chunks +11 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/bazel_test.dart View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Paul Berry
4 years, 1 month ago (2016-11-15 23:19:24 UTC) #2
Brian Wilkerson
I think that the default needs to be settable (static field?).
4 years, 1 month ago (2016-11-15 23:21:56 UTC) #3
Paul Berry
PTAL
4 years, 1 month ago (2016-11-16 03:27:48 UTC) #4
scheglov
LGTM
4 years, 1 month ago (2016-11-16 03:41:18 UTC) #5
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-16 15:14:37 UTC) #6
Paul Berry
4 years, 1 month ago (2016-11-16 17:52:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c6ad6fa114421ada6e89968c5b5d5832b30e32cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698