Avoid parsing the webstore base url so much.

extensions/common/extension_urls.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/extension_urls.h"
 
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "extensions/common/constants.h"
@@ skipping 15 matching lines @@
 }
 
 }  // namespace extensions
 
 namespace extension_urls {
 
 const char kChromeWebstoreBaseURL[] = "https://chrome.google.com/webstore";
 const char kChromeWebstoreUpdateURL[] =
     "https://clients2.google.com/service/update2/crx";
 
-std::string GetWebstoreLaunchURL() {
+GURL GetWebstoreLaunchURL() {
   extensions::ExtensionsClient* client = extensions::ExtensionsClient::Get();
   if (client)
     return client->GetWebstoreBaseURL();
-  return kChromeWebstoreBaseURL;
+  return GURL(kChromeWebstoreBaseURL);
 }
 
 std::string GetWebstoreExtensionsCategoryURL() {
-  return GetWebstoreLaunchURL() + "/category/extensions";
+  return GetWebstoreLaunchURL().spec() + "/category/extensions";

[Devlin, 2016/11/16 19:11:52]

Can we a) Add a TODO to convert these to return GURL and b) make this
GetWebstoreLaunchUrl().Resolve("category/extensions").spec() (and same for
GetWebstoreItemDetailURLPrefix())?

[Charlie Harrison, 2016/11/16 21:45:19]

Done, though using Resolve() is more expensive, because it does
canonicalization. I don't think these are bottlenecks though, so it's fine I
think.

 }
 
 std::string GetWebstoreItemDetailURLPrefix() {
-  return GetWebstoreLaunchURL() + "/detail/";
+  return GetWebstoreLaunchURL().spec() + "/detail/";
 }
 
 GURL GetWebstoreItemJsonDataURL(const std::string& extension_id) {
-  return GURL(GetWebstoreLaunchURL() + "/inlineinstall/detail/" + extension_id);
+  return GURL(GetWebstoreLaunchURL().spec() + "/inlineinstall/detail/" +
+              extension_id);
 }
 
 GURL GetWebstoreJsonSearchUrl(const std::string& query,
                               const std::string& host_language_code) {
-  GURL url(GetWebstoreLaunchURL() + "/jsonsearch");
+  GURL url(GetWebstoreLaunchURL().spec() + "/jsonsearch");
   url = net::AppendQueryParameter(url, "q", query);
   url = net::AppendQueryParameter(url, "hl", host_language_code);
   return url;
 }
 
 GURL GetWebstoreSearchPageUrl(const std::string& query) {
-  return GURL(GetWebstoreLaunchURL() + "/search/" +
+  return GURL(GetWebstoreLaunchURL().spec() + "/search/" +
               net::EscapeQueryParamValue(query, false));
 }
 
 GURL GetWebstoreUpdateUrl() {
   extensions::ExtensionsClient* client = extensions::ExtensionsClient::Get();
   if (client)
     return client->GetWebstoreUpdateURL();
   return GURL(kChromeWebstoreUpdateURL);
 }
 
 GURL GetWebstoreReportAbuseUrl(const std::string& extension_id,
                                const std::string& referrer_id) {
   return GURL(base::StringPrintf("%s/report/%s?utm_source=%s",
-                                 GetWebstoreLaunchURL().c_str(),
+                                 GetWebstoreLaunchURL().spec().c_str(),
                                  extension_id.c_str(), referrer_id.c_str()));
 }
 
 bool IsWebstoreUpdateUrl(const GURL& update_url) {
   GURL store_url = GetWebstoreUpdateUrl();
   return (update_url.host_piece() == store_url.host_piece() &&
           update_url.path_piece() == store_url.path_piece());
 }
 
 bool IsBlacklistUpdateUrl(const GURL& url) {
   extensions::ExtensionsClient* client = extensions::ExtensionsClient::Get();
   if (client)
     return client->IsBlacklistUpdateURL(url);
   return false;
 }
 
 }  // namespace extension_urls