Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2506693002:
Enable Initialization of the Task Scheduler by Default in the Browser Process (Closed)
DescriptionEnable Initialization of the Task Scheduler by Default in the Browser Process
This change also centralizes the initialization to components/task_scheduler.
BUG=662053
Committed: https://crrev.com/35980e3860cd6bb4241e9b4a6213048dcd6920e4
Cr-Commit-Position: refs/heads/master@{#433057}
Patch Set 1 #
Total comments: 10
Patch Set 2 : CR Feedback + Centralization #
Total comments: 30
Patch Set 3 : CR Feedback #Patch Set 4 : Rebase on edc8bea and Mark Dependent on https://crrev.com/2501763002 #Patch Set 5 : Rebase to 542c74f + Merge SequencedWorkerPool Enable Calls #Patch Set 6 : Rebase to 8f211d4 Unroll SequencedWorkerPool changes due to revert #
Messages
Total messages: 65 (35 generated)
robliao@chromium.org changed reviewers: + fdoray@chromium.org, gab@chromium.org
https://codereview.chromium.org/2506693002/diff/1/chrome/browser/chrome_brows... File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/2506693002/diff/1/chrome/browser/chrome_brows... chrome/browser/chrome_browser_main.cc:318: void MaybeInitializeTaskScheduler() { No Maybe https://codereview.chromium.org/2506693002/diff/1/chrome/browser/chrome_brows... chrome/browser/chrome_browser_main.cc:322: } To migrate WorkerPool call sites, TaskScheduler must always be initialized. Can you always initialize TaskScheduler and re-purpose this flag to enable/disable redirection only? You'll need to update IDS_FLAGS_BROWSER_TASK_SCHEDULER_DESCRIPTION. https://codereview.chromium.org/2506693002/diff/1/chrome/browser/chrome_brows... chrome/browser/chrome_browser_main.cc:330: variation_params["ForegroundFileIO"] = "8;32;0.3;0;30000"; To avoid duplication between iOS and other platforms, could you move these values to components/task_scheduler_util/initialization_util.cc? You could fall back on default values when some params are missing/invalid. You could even support a combination of default values and field trial values.
https://codereview.chromium.org/2506693002/diff/1/chrome/browser/chrome_brows... File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/2506693002/diff/1/chrome/browser/chrome_brows... chrome/browser/chrome_browser_main.cc:322: } On 2016/11/15 18:40:16, fdoray wrote: > To migrate WorkerPool call sites, TaskScheduler must always be initialized. Can > you always initialize TaskScheduler and re-purpose this flag to enable/disable > redirection only? You'll need to update > IDS_FLAGS_BROWSER_TASK_SCHEDULER_DESCRIPTION. Agreed, can't ever have a disabled scheduler. As discussed offline, update definition, but don't change flag name to avoid toggling people that already use it off of it. https://codereview.chromium.org/2506693002/diff/1/chrome/browser/chrome_brows... chrome/browser/chrome_browser_main.cc:330: variation_params["ForegroundFileIO"] = "8;32;0.3;0;30000"; On 2016/11/15 18:40:16, fdoray wrote: > To avoid duplication between iOS and other platforms, could you move these > values to components/task_scheduler_util/initialization_util.cc? You could fall > back on default values when some params are missing/invalid. You could even > support a combination of default values and field trial values. Need different defaults for OS_ANDROID too to match current Finch config. Also, it's weird that c/task_scheduler_util/initialization_util.cc is browser process specific. Can we find a more browser-specific name?
Description was changed from ========== Enable Initialization of the Task Scheduler by Default in the Browser Process BUG=553459 ========== to ========== Enable Initialization of the Task Scheduler by Default in the Browser Process This change also centralizes the initialization to components/task_scheduler. BUG=553459 ==========
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
Done. Thanks! https://codereview.chromium.org/2506693002/diff/1/chrome/browser/chrome_brows... File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/2506693002/diff/1/chrome/browser/chrome_brows... chrome/browser/chrome_browser_main.cc:318: void MaybeInitializeTaskScheduler() { On 2016/11/15 18:40:17, fdoray wrote: > No Maybe Done. https://codereview.chromium.org/2506693002/diff/1/chrome/browser/chrome_brows... chrome/browser/chrome_browser_main.cc:322: } On 2016/11/15 18:40:16, fdoray wrote: > To migrate WorkerPool call sites, TaskScheduler must always be initialized. Can > you always initialize TaskScheduler and re-purpose this flag to enable/disable > redirection only? You'll need to update > IDS_FLAGS_BROWSER_TASK_SCHEDULER_DESCRIPTION. Done. https://codereview.chromium.org/2506693002/diff/1/chrome/browser/chrome_brows... chrome/browser/chrome_browser_main.cc:322: } On 2016/11/15 20:40:33, gab wrote: > On 2016/11/15 18:40:16, fdoray wrote: > > To migrate WorkerPool call sites, TaskScheduler must always be initialized. > Can > > you always initialize TaskScheduler and re-purpose this flag to enable/disable > > redirection only? You'll need to update > > IDS_FLAGS_BROWSER_TASK_SCHEDULER_DESCRIPTION. > > Agreed, can't ever have a disabled scheduler. > > As discussed offline, update definition, but don't change flag name to avoid > toggling people that already use it off of it. Done. https://codereview.chromium.org/2506693002/diff/1/chrome/browser/chrome_brows... chrome/browser/chrome_browser_main.cc:330: variation_params["ForegroundFileIO"] = "8;32;0.3;0;30000"; On 2016/11/15 18:40:16, fdoray wrote: > To avoid duplication between iOS and other platforms, could you move these > values to components/task_scheduler_util/initialization_util.cc? You could fall > back on default values when some params are missing/invalid. You could even > support a combination of default values and field trial values. If some params are missing and invalid, we probably want to just use the default ones wholesale. Merging two configurations could lead to an unexpected configuration combination. As for where this lives, it's possible that we would use different values for iOS, and so we would have to split it out in the future, so keeping it separate seems reasonable for now. If we find values converging, then we can consider centralizing. https://codereview.chromium.org/2506693002/diff/1/chrome/browser/chrome_brows... chrome/browser/chrome_browser_main.cc:330: variation_params["ForegroundFileIO"] = "8;32;0.3;0;30000"; On 2016/11/15 20:40:33, gab wrote: > On 2016/11/15 18:40:16, fdoray wrote: > > To avoid duplication between iOS and other platforms, could you move these > > values to components/task_scheduler_util/initialization_util.cc? You could > fall > > back on default values when some params are missing/invalid. You could even > > support a combination of default values and field trial values. > > Need different defaults for OS_ANDROID too to match current Finch config. > > Also, it's weird that c/task_scheduler_util/initialization_util.cc is browser > process specific. Can we find a more browser-specific name? That's a natural result of the content DEPS restriction. Added Browser to the function name.
lgtm with nits https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... chrome/app/generated_resources.grd:13794: + Enables the browser task scheduler to dispatch tasks instead of the existing worker pools. Remove "browser" to allow this flag to control redirection in other processes. Maybe: "Enables redirection of some task posting APIs to the task scheduler." https://codereview.chromium.org/2506693002/diff/60001/chrome/browser/chrome_b... File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/2506693002/diff/60001/chrome/browser/chrome_b... chrome/browser/chrome_browser_main.cc:38: #include "base/threading/sequenced_worker_pool.h" Remove #include "base/threading/sequenced_worker_pool.h" https://codereview.chromium.org/2506693002/diff/60001/chrome/browser/chrome_b... chrome/browser/chrome_browser_main.cc:1222: task_scheduler_util::InitializeDefaultBrowserTaskScheduler(); Remove "Default"? https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... File components/task_scheduler_util/initialization_util.cc (right): https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/initialization_util.cc:22: #include "base/time/time.h" #include "build/build_config.h" https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/initialization_util.cc:113: // std::vector<base::SchedulerWOrkerPoolParams>. Returns an empty vector on WO -> Wo https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/initialization_util.cc:117: std::map<std::string, std::string> variation_params) { const std::map<>& https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/initialization_util.cc:168: variation_params = GetDefaultBrowserVariationParams(); no braces https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... File components/task_scheduler_util/initialization_util.h (right): https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/initialization_util.h:11: // derived from the variations system. , or default arguments if arguments are missing or invalid in the variations system.
lvg, please use bug # 662053 for this CL and also note that I think crbug.com/662052 and crbug.com/645196 are blockers to it. https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... chrome/app/generated_resources.grd:13787: + desc="Name of about:flag option to control redirection to the task scheduler." "to control experimental migration to the task scheduler" ? https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... chrome/app/generated_resources.grd:13794: + Enables the browser task scheduler to dispatch tasks instead of the existing worker pools. "Enables experimental migrations to the task scheduler." ? i.e. make it clear this is merely enabling more experimental stuff (and generic enough to encompass any future thing) https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... File components/task_scheduler_util/DEPS (right): https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/DEPS:2: "-components", This rule is automatic for all components, no need to add it explicitly. https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... File components/task_scheduler_util/initialization_util.cc (right): https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/initialization_util.cc:165: static constexpr char kFieldTrialName[] = "BrowserScheduler"; No static required for constexpr I think? https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/initialization_util.cc:169: } nit: no {} https://codereview.chromium.org/2506693002/diff/60001/ios/chrome/app/strings/... File ios/chrome/app/strings/ios_strings.grd (right): https://codereview.chromium.org/2506693002/diff/60001/ios/chrome/app/strings/... ios/chrome/app/strings/ios_strings.grd:256: desc="Name of about:flag option to control redirection to the task scheduler." ditto
On 2016/11/16 19:32:17, gab wrote: > lvg, please use bug # 662053 for this CL and also note that I think > crbug.com/662052 and crbug.com/645196 are blockers to it. For crbug.com/662052, I'm okay with a follow-up CL shortly after if that makes the order easier. > > https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... > File chrome/app/generated_resources.grd (right): > > https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... > chrome/app/generated_resources.grd:13787: + desc="Name of > about:flag option to control redirection to the task scheduler." > "to control experimental migration to the task scheduler" ? > > https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... > chrome/app/generated_resources.grd:13794: + Enables the browser task > scheduler to dispatch tasks instead of the existing worker pools. > "Enables experimental migrations to the task scheduler." ? > > i.e. make it clear this is merely enabling more experimental stuff (and generic > enough to encompass any future thing) > > https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... > File components/task_scheduler_util/DEPS (right): > > https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... > components/task_scheduler_util/DEPS:2: "-components", > This rule is automatic for all components, no need to add it explicitly. > > https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... > File components/task_scheduler_util/initialization_util.cc (right): > > https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... > components/task_scheduler_util/initialization_util.cc:165: static constexpr char > kFieldTrialName[] = "BrowserScheduler"; > No static required for constexpr I think? > > https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... > components/task_scheduler_util/initialization_util.cc:169: } > nit: no {} > > https://codereview.chromium.org/2506693002/diff/60001/ios/chrome/app/strings/... > File ios/chrome/app/strings/ios_strings.grd (right): > > https://codereview.chromium.org/2506693002/diff/60001/ios/chrome/app/strings/... > ios/chrome/app/strings/ios_strings.grd:256: desc="Name of about:flag option to > control redirection to the task scheduler." > ditto
Description was changed from ========== Enable Initialization of the Task Scheduler by Default in the Browser Process This change also centralizes the initialization to components/task_scheduler. BUG=553459 ========== to ========== Enable Initialization of the Task Scheduler by Default in the Browser Process This change also centralizes the initialization to components/task_scheduler. BUG=662053 ==========
https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... chrome/app/generated_resources.grd:13787: + desc="Name of about:flag option to control redirection to the task scheduler." On 2016/11/16 19:32:17, gab wrote: > "to control experimental migration to the task scheduler" ? The main thing this flag does is enable or disable redirection, right? We can't change the state of the migration once we start. Redirection is most appropriate here. If we start to cover more than redirection, then a new flag might be in order. https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... chrome/app/generated_resources.grd:13794: + Enables the browser task scheduler to dispatch tasks instead of the existing worker pools. On 2016/11/16 19:23:59, fdoray wrote: > Remove "browser" to allow this flag to control redirection in other processes. > Maybe: "Enables redirection of some task posting APIs to the task scheduler." Done. https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... chrome/app/generated_resources.grd:13794: + Enables the browser task scheduler to dispatch tasks instead of the existing worker pools. On 2016/11/16 19:32:17, gab wrote: > "Enables experimental migrations to the task scheduler." ? > > i.e. make it clear this is merely enabling more experimental stuff (and generic > enough to encompass any future thing) See above. https://codereview.chromium.org/2506693002/diff/60001/chrome/browser/chrome_b... File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/2506693002/diff/60001/chrome/browser/chrome_b... chrome/browser/chrome_browser_main.cc:38: #include "base/threading/sequenced_worker_pool.h" On 2016/11/16 19:23:59, fdoray wrote: > Remove #include "base/threading/sequenced_worker_pool.h" Done. https://codereview.chromium.org/2506693002/diff/60001/chrome/browser/chrome_b... chrome/browser/chrome_browser_main.cc:1222: task_scheduler_util::InitializeDefaultBrowserTaskScheduler(); On 2016/11/16 19:23:59, fdoray wrote: > Remove "Default"? Technically it is the default one (we provide it), so I'd rather leave it here. https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... File components/task_scheduler_util/DEPS (right): https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/DEPS:2: "-components", On 2016/11/16 19:32:17, gab wrote: > This rule is automatic for all components, no need to add it explicitly. Done. https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... File components/task_scheduler_util/initialization_util.cc (right): https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/initialization_util.cc:22: #include "base/time/time.h" On 2016/11/16 19:23:59, fdoray wrote: > #include "build/build_config.h" Done. https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/initialization_util.cc:113: // std::vector<base::SchedulerWOrkerPoolParams>. Returns an empty vector on On 2016/11/16 19:23:59, fdoray wrote: > WO -> Wo Done. https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/initialization_util.cc:117: std::map<std::string, std::string> variation_params) { On 2016/11/16 19:23:59, fdoray wrote: > const std::map<>& Done. https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/initialization_util.cc:165: static constexpr char kFieldTrialName[] = "BrowserScheduler"; On 2016/11/16 19:32:17, gab wrote: > No static required for constexpr I think? See http://stackoverflow.com/questions/13865842/does-static-constexpr-variable-ma... constexpr is for the benefit of the compiler and static describes the runtime rules (don't put this address on the stack). https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/initialization_util.cc:168: variation_params = GetDefaultBrowserVariationParams(); On 2016/11/16 19:23:59, fdoray wrote: > no braces Done. https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/initialization_util.cc:169: } On 2016/11/16 19:32:17, gab wrote: > nit: no {} Done. https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... File components/task_scheduler_util/initialization_util.h (right): https://codereview.chromium.org/2506693002/diff/60001/components/task_schedul... components/task_scheduler_util/initialization_util.h:11: // derived from the variations system. On 2016/11/16 19:23:59, fdoray wrote: > , or default arguments if arguments are missing or invalid in the variations > system. Changed. https://codereview.chromium.org/2506693002/diff/60001/ios/chrome/app/strings/... File ios/chrome/app/strings/ios_strings.grd (right): https://codereview.chromium.org/2506693002/diff/60001/ios/chrome/app/strings/... ios/chrome/app/strings/ios_strings.grd:256: desc="Name of about:flag option to control redirection to the task scheduler." On 2016/11/16 19:32:17, gab wrote: > ditto See previous.
https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... chrome/app/generated_resources.grd:13787: + desc="Name of about:flag option to control redirection to the task scheduler." On 2016/11/16 19:42:55, robliao wrote: > On 2016/11/16 19:32:17, gab wrote: > > "to control experimental migration to the task scheduler" ? > > The main thing this flag does is enable or disable redirection, right? We can't > change the state of the migration once we start. > Redirection is most appropriate here. If we start to cover more than > redirection, then a new flag might be in order. What I want is for it to be so generic we can put whatever we please behind it. People enabling it == us and a few people that care to try or new things. People disabling it == want to shutdown every experimental thing we have for "reasons".
https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2506693002/diff/60001/chrome/app/generated_re... chrome/app/generated_resources.grd:13787: + desc="Name of about:flag option to control redirection to the task scheduler." On 2016/11/16 19:45:48, gab wrote: > On 2016/11/16 19:42:55, robliao wrote: > > On 2016/11/16 19:32:17, gab wrote: > > > "to control experimental migration to the task scheduler" ? > > > > The main thing this flag does is enable or disable redirection, right? We > can't > > change the state of the migration once we start. > > Redirection is most appropriate here. If we start to cover more than > > redirection, then a new flag might be in order. > > What I want is for it to be so generic we can put whatever we please behind it. > > People enabling it == us and a few people that care to try or new things. > People disabling it == want to shutdown every experimental thing we have for > "reasons". Discussed offline.
lgtm % I'd still like to see the blocking bugs addressed before landing
On 2016/11/16 20:10:25, gab wrote: > lgtm % I'd still like to see the blocking bugs addressed before landing I think we can land this even with the blocking bugs. 1) Auditing TrackedObjects This prevents migration, but not turning on the TaskScheduler by default. 2) Do not create threads from PreCreateThreads Landing this first will make the move easier. The single call in chrome_browser_main.cc will move (and potentially need another refactor for variations).
robliao@chromium.org changed reviewers: + brettw@chromium.org, sdefresne@chromium.org
brettw@chromium.org: Please review changes in chrome/* components/* sdefresne@chromium.org: Please review changes in ios/* Thanks!
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
ios/ lgtm
On 2016/11/16 20:35:51, robliao wrote: > https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=brettw@chromium.org: Please review changes in > chrome/* > components/* We are owners of components/task_scheduler_util/ right? So Brett merely needs to approve code moved out of chrome_browser_main.cc? > > https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=sdefresne@chromium.org: Please review changes in > ios/* > > Thanks!
c_b_m lgtm
On 2016/11/17 14:41:26, gab wrote: > On 2016/11/16 20:35:51, robliao wrote: > > https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=brettw@chromium.org: Please > review changes in > > chrome/* > > components/* > > We are owners of components/task_scheduler_util/ right? So Brett merely needs to > approve code moved out of chrome_browser_main.cc? > > > > > https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=sdefresne@chromium.org: > Please review changes in > > ios/* > > > > Thanks! Indeed we are! Some goofyness on the Chromium Butler end here.
On 2016/11/17 14:57:40, robliao wrote: > On 2016/11/17 14:41:26, gab wrote: > > On 2016/11/16 20:35:51, robliao wrote: > > > https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=brettw@chromium.org: > Please > > review changes in > > > chrome/* > > > components/* > > > > We are owners of components/task_scheduler_util/ right? So Brett merely needs > to > > approve code moved out of chrome_browser_main.cc? > > > > > > > > https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=sdefresne@chromium.org: > > Please review changes in > > > ios/* > > > > > > Thanks! > > Indeed we are! Some goofyness on the Chromium Butler end here. Yea, I think the extension doesn't understand the file:// attribute in the OWNERS file.
Patchset #4 (id:100001) has been deleted
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by robliao@chromium.org
The CQ bit was checked by robliao@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fdoray@chromium.org, gab@chromium.org, brettw@chromium.org, sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2506693002/#ps120001 (title: "Rebase on edc8bea and Mark Dependent on https://crrev.com/2501763002")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Patchset #5 (id:140001) has been deleted
fdoray: Please sanity check the SequencedWorkerPool changes merge. Thanks!
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Enable SWP change lgtm
The CQ bit was unchecked by robliao@chromium.org
The CQ bit was checked by robliao@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org, brettw@chromium.org, sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2506693002/#ps160001 (title: "Rebase to 542c74f + Merge SequencedWorkerPool Enable Calls")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by robliao@chromium.org
The CQ bit was checked by robliao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by robliao@chromium.org
The CQ bit was checked by robliao@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org, brettw@chromium.org, fdoray@chromium.org, sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/2506693002/#ps180001 (title: "Rebase to 8f211d4 Unroll SequencedWorkerPool changes due to revert")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was checked by robliao@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable Initialization of the Task Scheduler by Default in the Browser Process This change also centralizes the initialization to components/task_scheduler. BUG=662053 ========== to ========== Enable Initialization of the Task Scheduler by Default in the Browser Process This change also centralizes the initialization to components/task_scheduler. BUG=662053 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:180001)
Message was sent while issue was closed.
Description was changed from ========== Enable Initialization of the Task Scheduler by Default in the Browser Process This change also centralizes the initialization to components/task_scheduler. BUG=662053 ========== to ========== Enable Initialization of the Task Scheduler by Default in the Browser Process This change also centralizes the initialization to components/task_scheduler. BUG=662053 Committed: https://crrev.com/35980e3860cd6bb4241e9b4a6213048dcd6920e4 Cr-Commit-Position: refs/heads/master@{#433057} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/35980e3860cd6bb4241e9b4a6213048dcd6920e4 Cr-Commit-Position: refs/heads/master@{#433057} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
