components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java - Issue 2506653003: Instrument CronetUrlRequestTest#testThrowOrCancelInOnCanceled flaky test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java

Issue 2506653003: Instrument CronetUrlRequestTest#testThrowOrCancelInOnCanceled flaky test (Closed)

Patch Set: Spelling fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/UploadDataProvidersTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java b/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java

index 6d1254f3f9e0810ba714ea2daf2bf57c64de1cf5..b2a0163d508ba637dcc6ecf9a08a293d54816af2 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestCallback.java

@@ -13,6 +13,8 @@ import static junit.framework.Assert.assertNotNull;

import static junit.framework.Assert.assertNull;

import static junit.framework.Assert.assertTrue;

+import static org.chromium.net.CronetTestBase.assertContains;

import org.chromium.net.impl.UrlRequestError;

import java.nio.ByteBuffer;

@@ -254,10 +256,10 @@ class TestUrlRequestCallback extends UrlRequest.Callback {

if (mListenerExceptionThrown) {

assertEquals(UrlRequestError.LISTENER_EXCEPTION_THROWN, error.getErrorCode());

assertEquals(0, error.getCronetInternalErrorCode());

- assertEquals("Exception received from UrlRequest.Callback", error.getMessage());

+ assertContains("Exception received from UrlRequest.Callback", error.getMessage());

assertNotNull(error.getCause());

assertTrue(error.getCause() instanceof IllegalStateException);

- assertEquals("Listener Exception.", error.getCause().getMessage());

+ assertContains("Listener Exception.", error.getCause().getMessage());

assertFalse(error.immediatelyRetryable());

}