Instrument CronetUrlRequestTest#testThrowOrCancelInOnCanceled flaky test

components/cronet/android/api/src/org/chromium/net/UrlRequestException.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import java.io.IOException;
 
 /**
  * Exception passed to {@link UrlRequest.Callback#onFailed UrlRequest.Callback.onFailed()} when:
@@ skipping 143 matching lines @@
             default:
                 return false;
             case ERROR_NETWORK_CHANGED:
             case ERROR_TIMED_OUT:
             case ERROR_CONNECTION_CLOSED:
             case ERROR_CONNECTION_TIMED_OUT:
             case ERROR_CONNECTION_RESET:
                 return true;
         }
     }
+
+    @Override
+    public String toString() {

[Charles, 2016/11/15 19:08:16]

Usually the preferred way to do this would be to add this information to the
"message" argument of the superclass's constructor. It's not really idiomatic to
override toString on an exception.

[kapishnikov, 2016/11/15 21:17:01]

I cannot pass the augmented message to the supertype constructor but I can
override the getMessage() method. See the change.

[Charles, 2016/11/15 21:38:22]

Why can't you pass it to the supertype constructor?

+        StringBuilder b = new StringBuilder();
+        b.append(super.toString());
+        b.append(", ErrorCode=").append(mErrorCode);
+        if (mCronetInternalErrorCode != 0) {
+            b.append(", InternalErrorCode=").append(mCronetInternalErrorCode);
+        }
+        b.append(", Retriable=").append(immediatelyRetryable());
+        if (getCause() != null) {
+            b.append(", Cause=").append(getCause().toString());
+        }
+        return b.toString();
+    }
 }