Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 250663002: Wait for BrowsingDataRemover to complete in prerender tests. (Closed)

Created:
6 years, 8 months ago by davidben
Modified:
6 years, 7 months ago
Reviewers:
tburkard
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org
Visibility:
Public.

Description

Wait for BrowsingDataRemover to complete in prerender tests. BrowsingDataRemover causes shutdown problems if interrupted. Avoid test flakiness by letting it run to completion. BUG=316225, 340855 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
davidben
6 years, 8 months ago (2014-04-24 18:48:24 UTC) #1
tburkard
lgtm
6 years, 7 months ago (2014-04-29 20:31:40 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 7 months ago (2014-04-29 20:53:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/250663002/1
6 years, 7 months ago (2014-04-29 20:55:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 22:06:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 22:06:59 UTC) #6
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 7 months ago (2014-04-29 22:08:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/250663002/1
6 years, 7 months ago (2014-04-29 22:12:43 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 06:55:52 UTC) #9
Message was sent while issue was closed. 
Change committed as 267106

Powered by Google App Engine
This is Rietveld 408576698