Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 2506613002: Move allow_lazy from ParserBase to Parser and remove accessors (Closed)

Created:
4 years, 1 month ago by Toon Verwaest
Modified:
4 years, 1 month ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move allow_lazy from ParserBase to Parser and remove accessors BUG= Committed: https://crrev.com/feb787714c6259f4f9406299f9d38f8652f3af21 Cr-Commit-Position: refs/heads/master@{#41031}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Move allow_lazy from ParserBase to Parser and remove accessors #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -22 lines) Patch
M src/parsing/parser.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/parsing/parser.cc View 1 2 6 chunks +6 lines, -8 lines 0 comments Download
M src/parsing/parser-base.h View 1 3 chunks +0 lines, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 9 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Toon Verwaest
ptal
4 years, 1 month ago (2016-11-15 12:32:40 UTC) #2
vogelheim
lgtm. Nice!
4 years, 1 month ago (2016-11-15 16:01:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506613002/20001
4 years, 1 month ago (2016-11-15 16:58:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/24829) v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-15 17:01:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506613002/40001
4 years, 1 month ago (2016-11-16 12:03:52 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/12233) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-16 12:06:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506613002/60001
4 years, 1 month ago (2016-11-16 12:15:12 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-16 12:40:24 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:36:05 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/feb787714c6259f4f9406299f9d38f8652f3af21
Cr-Commit-Position: refs/heads/master@{#41031}

Powered by Google App Engine
This is Rietveld 408576698