Hide dismiss button on toast when doing partial screenshot using stylus tools.

Hide dismiss button on toast when doing partial screenshot using stylus tools.

Users click the toast dismiss button using the stylus, which takes a screenshot
instead of actually dismissing the toast. Since the toast is relatively short
(2.5s), hiding the dismiss button should be fine.

BUG=665630
Committed: https://crrev.com/a30f7c13368b199d06079d313086553f26509342
Cr-Commit-Position: refs/heads/master@{#432977}

[jdufault, 2016-11-15 21:00:42]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 21:01:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 21:20:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 21:20:01]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[jdufault, 2016-11-15 23:13:07]

Description was changed from

==========
Hide dismiss button on toast when doing partial screenshot using stylus tools.

Users click the toast dismiss button using the stylus, which takes a screenshot
instead of actually dismissing the toast. Since the toast is relatively short
(2.5s), hiding the dismiss button should be fine.

BUG=
==========

to

==========
Hide dismiss button on toast when doing partial screenshot using stylus tools.

Users click the toast dismiss button using the stylus, which takes a screenshot
instead of actually dismissing the toast. Since the toast is relatively short
(2.5s), hiding the dismiss button should be fine.

BUG=665630
==========

[jdufault, 2016-11-15 23:13:07]

jdufault@chromium.org changed reviewers:
+ yoshiki@chromium.org

[jdufault, 2016-11-15 23:13:50]

yoshiki@ PTAL. Thanks!

[yoshiki, 2016-11-16 04:22:45]

lgtm. Thanks!

https://codereview.chromium.org/2506583005/diff/1/ash/common/system/toast/toa...
File ash/common/system/toast/toast_overlay.cc (right):

https://codereview.chromium.org/2506583005/diff/1/ash/common/system/toast/toa...
ash/common/system/toast/toast_overlay.cc:308:
overlay_view_->button()->NotifyClick(event);
nit: Could you add DCHECK(overlay_view_->button()) in this method? Since now
overlay_view_->button() can be null.

[jdufault, 2016-11-16 19:12:52]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 19:13:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2016-11-16 19:13:57]

https://codereview.chromium.org/2506583005/diff/1/ash/common/system/toast/toa...
File ash/common/system/toast/toast_overlay.cc (right):

https://codereview.chromium.org/2506583005/diff/1/ash/common/system/toast/toa...
ash/common/system/toast/toast_overlay.cc:308:
overlay_view_->button()->NotifyClick(event);
On 2016/11/16 04:22:45, yoshiki wrote:
> nit: Could you add DCHECK(overlay_view_->button()) in this method? Since now
> overlay_view_->button() can be null.

Done.

[jdufault, 2016-11-16 19:14:07]

jdufault@chromium.org changed reviewers:
+ stevenjb@chromium.org

[jdufault, 2016-11-16 19:14:39]

stevenjb@ PTAL a quick look, need owner lgtm.

[stevenjb, 2016-11-16 20:59:27]

lgtm

[jdufault, 2016-11-16 21:57:52]

The CQ bit was unchecked by jdufault@chromium.org

[jdufault, 2016-11-16 21:57:52]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-11-16 21:57:53]

The patchset sent to the CQ was uploaded after l-g-t-m from yoshiki@chromium.org
Link to the patchset: https://codereview.chromium.org/2506583005/#ps20001
(title: "Add DCHECK")

[commit-bot: I haz the power, 2016-11-16 21:58:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 01:52:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 01:52:24]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jdufault, 2016-11-17 18:49:12]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2016-11-17 18:50:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 21:48:27]

Description was changed from

==========
Hide dismiss button on toast when doing partial screenshot using stylus tools.

Users click the toast dismiss button using the stylus, which takes a screenshot
instead of actually dismissing the toast. Since the toast is relatively short
(2.5s), hiding the dismiss button should be fine.

BUG=665630
==========

to

==========
Hide dismiss button on toast when doing partial screenshot using stylus tools.

Users click the toast dismiss button using the stylus, which takes a screenshot
instead of actually dismissing the toast. Since the toast is relatively short
(2.5s), hiding the dismiss button should be fine.

BUG=665630
==========

[commit-bot: I haz the power, 2016-11-17 21:48:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 21:51:50]

Description was changed from

==========
Hide dismiss button on toast when doing partial screenshot using stylus tools.

Users click the toast dismiss button using the stylus, which takes a screenshot
instead of actually dismissing the toast. Since the toast is relatively short
(2.5s), hiding the dismiss button should be fine.

BUG=665630
==========

to

==========
Hide dismiss button on toast when doing partial screenshot using stylus tools.

Users click the toast dismiss button using the stylus, which takes a screenshot
instead of actually dismissing the toast. Since the toast is relatively short
(2.5s), hiding the dismiss button should be fine.

BUG=665630

Committed: https://crrev.com/a30f7c13368b199d06079d313086553f26509342
Cr-Commit-Position: refs/heads/master@{#432977}
==========

[commit-bot: I haz the power, 2016-11-17 21:51:51]

Patchset 2 (id:??) landed as
https://crrev.com/a30f7c13368b199d06079d313086553f26509342
Cr-Commit-Position: refs/heads/master@{#432977}

[stgao, 2016-11-21 19:57:40]

FYI: this CL seems to introduce a new flaky test
ToastManagerTest.NullMessageHasNoDismissButton

https://findit-for-me.appspot.com/waterfall/check-flake?master_name=chromium....
(Note: Findit got it wrong with build 54817, but the CL was first included in
build 54809)


One occurrence on Waterfall is
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)/bu...