Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h

Issue 2506553002: Scheduler: Deprecate CancellableTaskFactory in favor of WebTaskRunner::postCancellableTask (Closed)
Patch Set: add comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h
diff --git a/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h b/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h
index d6ab98856c51e82b36ee91a7456f886288642f22..3a7d81dce4684844a4247717ba4f5abb6a964ab7 100644
--- a/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h
+++ b/third_party/WebKit/Source/platform/scheduler/CancellableTaskFactory.h
@@ -40,19 +40,16 @@ class PLATFORM_EXPORT CancellableTaskFactory {
USING_FAST_MALLOC(CancellableTaskFactory);
public:
- // A pair of mutually exclusive factory methods are provided for constructing
- // a CancellableTaskFactory, one for when a Oilpan heap object owns a
- // CancellableTaskFactory, and one when that owning object isn't controlled
- // by Oilpan.
- //
- // In the Oilpan case, as WTF::Closure objects are off-heap, we have to
- // construct the closure in such a manner that it doesn't end up referring
- // back to the owning heap object with a strong Persistent<> GC root
- // reference. If we do, this will create a heap <-> off-heap cycle and leak,
- // the owning object can never be GCed. Instead, the closure will keep an
- // off-heap persistent reference of the weak, which will refer back to the
- // owner heap object safely (but weakly.)
+ // As WTF::Closure objects are off-heap, we have to construct the closure in
+ // such a manner that it doesn't end up referring back to the owning heap
+ // object with a strong Persistent<> GC root reference. If we do, this will
+ // create a heap <-> off-heap cycle and leak, the owning object can never be
+ // GCed. Instead, the closure will keep an off-heap persistent reference of
+ // the weak, which will refer back to the owner heap object safely (but
+ // weakly.)
//
+ // DEPRECATED: Please use WebTaskRunner::postCancellableTask instead.
+ // (https://crbug.com/665285)
template <typename T>
static std::unique_ptr<CancellableTaskFactory> create(
T* thisObject,
@@ -63,16 +60,6 @@ class PLATFORM_EXPORT CancellableTaskFactory {
WTF::bind(method, wrapWeakPersistent(thisObject))));
}
- template <typename T>
- static std::unique_ptr<CancellableTaskFactory> create(
- T* thisObject,
- void (T::*method)(),
- typename std::enable_if<!IsGarbageCollectedType<T>::value>::type* =
- nullptr) {
- return wrapUnique(new CancellableTaskFactory(
- WTF::bind(method, WTF::unretained(thisObject))));
- }
-
bool isPending() const { return m_weakPtrFactory.hasWeakPtrs(); }
void cancel();

Powered by Google App Engine
This is Rietveld 408576698