Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Anticipating AVStream.codec->coded_{width,height} will be inaccessible in
ffmpeg soon, this change uses just the width and height values as hints
of the coded size in AVStreamToVideoDecoderConfig (used only in
FFmpegDemuxerStream creation and tests). Once AVStream.codec becomes
deprecated, coded size fields are not externally populated unless we
spin up a temporary ffmpeg decoder to obtain that information.

It also drops the metadata logging in OnFindStreamInfoDone for
coded_size, since that metadata is no longer different than just width
and height, which are already logged.

Note that MSE MP4 parser has always just used the width, height for
coded size in similar construction of VideoDecoderConfigs in
MP4StreamParser.  MSE mp2t and WebM stream parsers appear to populate
coded size more precisely.

Marks VideoDecoderConfig.coded_size() and related histograms.xml
entries as deprecated.

BUG=591845, 665539
TEST=No media_unittests, ffmpeg_regression_tests regression under LSAN on linux

Committed: https://crrev.com/29241f214adfd993990b409c8f42dca858775dc9
Cr-Commit-Position: refs/heads/master@{#432300}

[wolenetz, 2016-11-15 03:00:12]

Please take a look. Thanks.

[wolenetz, 2016-11-15 03:00:17]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 03:01:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wolenetz, 2016-11-15 03:03:49]

Description was changed from

==========
Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Anticipating AVStream.codec.coded_{width,height} will be inaccessible in
ffmpeg soon, this change uses just the width and height values as hints
of the coded size in AVStreamToVideoDecoderConfig (used only in
FFmpegDemuxerStream creation and tests). Once AVStream.codec becomes
deprecated, coded size fields are not externally populated unless we
spin up a temporary ffmpeg decoder to obtain that information.

It also drops the metadata logging in OnFindStreamInfoDone for
coded_size, since that metadata is no longer different than just width
and height, which are already logged.

Note that MSE MP4 parser has always just used the width, height for
coded size in similar construction of VideoDecoderConfigs in
MP4StreamParser.  MSE mp2t and WebM stream parsers appear to populate
coded size more precisely.

BUG=591845
R=dalecurtis@chromium.org
TEST=media_unittests, ffmpeg_regression_tests all pass under LSAN on linux
==========

to

==========
Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Anticipating AVStream.codec->coded_{width,height} will be inaccessible in
ffmpeg soon, this change uses just the width and height values as hints
of the coded size in AVStreamToVideoDecoderConfig (used only in
FFmpegDemuxerStream creation and tests). Once AVStream.codec becomes
deprecated, coded size fields are not externally populated unless we
spin up a temporary ffmpeg decoder to obtain that information.

It also drops the metadata logging in OnFindStreamInfoDone for
coded_size, since that metadata is no longer different than just width
and height, which are already logged.

Note that MSE MP4 parser has always just used the width, height for
coded size in similar construction of VideoDecoderConfigs in
MP4StreamParser.  MSE mp2t and WebM stream parsers appear to populate
coded size more precisely.

BUG=591845
R=dalecurtis@chromium.org
TEST=media_unittests, ffmpeg_regression_tests all pass under LSAN on linux
==========

[wolenetz, 2016-11-15 03:07:52]

Description was changed from

==========
Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Anticipating AVStream.codec->coded_{width,height} will be inaccessible in
ffmpeg soon, this change uses just the width and height values as hints
of the coded size in AVStreamToVideoDecoderConfig (used only in
FFmpegDemuxerStream creation and tests). Once AVStream.codec becomes
deprecated, coded size fields are not externally populated unless we
spin up a temporary ffmpeg decoder to obtain that information.

It also drops the metadata logging in OnFindStreamInfoDone for
coded_size, since that metadata is no longer different than just width
and height, which are already logged.

Note that MSE MP4 parser has always just used the width, height for
coded size in similar construction of VideoDecoderConfigs in
MP4StreamParser.  MSE mp2t and WebM stream parsers appear to populate
coded size more precisely.

BUG=591845
R=dalecurtis@chromium.org
TEST=media_unittests, ffmpeg_regression_tests all pass under LSAN on linux
==========

to

==========
Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Anticipating AVStream.codec->coded_{width,height} will be inaccessible in
ffmpeg soon, this change uses just the width and height values as hints
of the coded size in AVStreamToVideoDecoderConfig (used only in
FFmpegDemuxerStream creation and tests). Once AVStream.codec becomes
deprecated, coded size fields are not externally populated unless we
spin up a temporary ffmpeg decoder to obtain that information.

It also drops the metadata logging in OnFindStreamInfoDone for
coded_size, since that metadata is no longer different than just width
and height, which are already logged.

Note that MSE MP4 parser has always just used the width, height for
coded size in similar construction of VideoDecoderConfigs in
MP4StreamParser.  MSE mp2t and WebM stream parsers appear to populate
coded size more precisely.

BUG=591845
R=dalecurtis@chromium.org
TEST=No media_unittests, ffmpeg_regression_tests regression under LSAN on linux
==========

[commit-bot: I haz the power, 2016-11-15 05:02:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 05:02:48]

Dry run: This issue passed the CQ dry run.

[DaleCurtis, 2016-11-15 19:18:22]

https://codereview.chromium.org/2506533002/diff/1/media/ffmpeg/ffmpeg_common.cc
File media/ffmpeg/ffmpeg_common.cc (right):

https://codereview.chromium.org/2506533002/diff/1/media/ffmpeg/ffmpeg_common....
media/ffmpeg/ffmpeg_common.cc:444: // Anticipating
AVStream.codec.coded_{width,height} will be inaccessible in
Mark VideoDecoderConfig coded_{width,height} as deprecated and add a tracking
bug to remove.

https://codereview.chromium.org/2506533002/diff/1/media/filters/ffmpeg_demuxe...
File media/filters/ffmpeg_demuxer.cc (left):

https://codereview.chromium.org/2506533002/diff/1/media/filters/ffmpeg_demuxe...
media/filters/ffmpeg_demuxer.cc:164:
UMA_HISTOGRAM_COUNTS_10000("Media.VideoCodedWidth",
Mark histograms.xml entries as deprecated.

[wolenetz, 2016-11-15 20:02:18]

Description was changed from

==========
Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Anticipating AVStream.codec->coded_{width,height} will be inaccessible in
ffmpeg soon, this change uses just the width and height values as hints
of the coded size in AVStreamToVideoDecoderConfig (used only in
FFmpegDemuxerStream creation and tests). Once AVStream.codec becomes
deprecated, coded size fields are not externally populated unless we
spin up a temporary ffmpeg decoder to obtain that information.

It also drops the metadata logging in OnFindStreamInfoDone for
coded_size, since that metadata is no longer different than just width
and height, which are already logged.

Note that MSE MP4 parser has always just used the width, height for
coded size in similar construction of VideoDecoderConfigs in
MP4StreamParser.  MSE mp2t and WebM stream parsers appear to populate
coded size more precisely.

BUG=591845
R=dalecurtis@chromium.org
TEST=No media_unittests, ffmpeg_regression_tests regression under LSAN on linux
==========

to

==========
Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Anticipating AVStream.codec->coded_{width,height} will be inaccessible in
ffmpeg soon, this change uses just the width and height values as hints
of the coded size in AVStreamToVideoDecoderConfig (used only in
FFmpegDemuxerStream creation and tests). Once AVStream.codec becomes
deprecated, coded size fields are not externally populated unless we
spin up a temporary ffmpeg decoder to obtain that information.

It also drops the metadata logging in OnFindStreamInfoDone for
coded_size, since that metadata is no longer different than just width
and height, which are already logged.

Note that MSE MP4 parser has always just used the width, height for
coded size in similar construction of VideoDecoderConfigs in
MP4StreamParser.  MSE mp2t and WebM stream parsers appear to populate
coded size more precisely.

BUG=591845
TEST=No media_unittests, ffmpeg_regression_tests regression under LSAN on linux
==========

[wolenetz, 2016-11-15 20:03:00]

wolenetz@chromium.org changed reviewers:
+ holte@chromium.org

[wolenetz, 2016-11-15 20:03:01]

Please take a look at patch set 2; all previous comments are addressed.

dalecurtis@: everything
holte@: histograms.xml

Thanks!

https://codereview.chromium.org/2506533002/diff/1/media/ffmpeg/ffmpeg_common.cc
File media/ffmpeg/ffmpeg_common.cc (right):

https://codereview.chromium.org/2506533002/diff/1/media/ffmpeg/ffmpeg_common....
media/ffmpeg/ffmpeg_common.cc:444: // Anticipating
AVStream.codec.coded_{width,height} will be inaccessible in
On 2016/11/15 19:18:22, DaleCurtis wrote:
> Mark VideoDecoderConfig coded_{width,height} as deprecated and add a tracking
> bug to remove.

Done.

https://codereview.chromium.org/2506533002/diff/1/media/filters/ffmpeg_demuxe...
File media/filters/ffmpeg_demuxer.cc (left):

https://codereview.chromium.org/2506533002/diff/1/media/filters/ffmpeg_demuxe...
media/filters/ffmpeg_demuxer.cc:164:
UMA_HISTOGRAM_COUNTS_10000("Media.VideoCodedWidth",
On 2016/11/15 19:18:22, DaleCurtis wrote:
> Mark histograms.xml entries as deprecated.

Done.

[wolenetz, 2016-11-15 20:03:11]

The CQ bit was checked by wolenetz@chromium.org to run a CQ dry run

[wolenetz, 2016-11-15 20:04:11]

Description was changed from

==========
Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Anticipating AVStream.codec->coded_{width,height} will be inaccessible in
ffmpeg soon, this change uses just the width and height values as hints
of the coded size in AVStreamToVideoDecoderConfig (used only in
FFmpegDemuxerStream creation and tests). Once AVStream.codec becomes
deprecated, coded size fields are not externally populated unless we
spin up a temporary ffmpeg decoder to obtain that information.

It also drops the metadata logging in OnFindStreamInfoDone for
coded_size, since that metadata is no longer different than just width
and height, which are already logged.

Note that MSE MP4 parser has always just used the width, height for
coded size in similar construction of VideoDecoderConfigs in
MP4StreamParser.  MSE mp2t and WebM stream parsers appear to populate
coded size more precisely.

BUG=591845
TEST=No media_unittests, ffmpeg_regression_tests regression under LSAN on linux
==========

to

==========
Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Anticipating AVStream.codec->coded_{width,height} will be inaccessible in
ffmpeg soon, this change uses just the width and height values as hints
of the coded size in AVStreamToVideoDecoderConfig (used only in
FFmpegDemuxerStream creation and tests). Once AVStream.codec becomes
deprecated, coded size fields are not externally populated unless we
spin up a temporary ffmpeg decoder to obtain that information.

It also drops the metadata logging in OnFindStreamInfoDone for
coded_size, since that metadata is no longer different than just width
and height, which are already logged.

Note that MSE MP4 parser has always just used the width, height for
coded size in similar construction of VideoDecoderConfigs in
MP4StreamParser.  MSE mp2t and WebM stream parsers appear to populate
coded size more precisely.

BUG=591845, 665539
TEST=No media_unittests, ffmpeg_regression_tests regression under LSAN on linux
==========

[commit-bot: I haz the power, 2016-11-15 20:04:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wolenetz, 2016-11-15 20:06:07]

Description was changed from

==========
Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Anticipating AVStream.codec->coded_{width,height} will be inaccessible in
ffmpeg soon, this change uses just the width and height values as hints
of the coded size in AVStreamToVideoDecoderConfig (used only in
FFmpegDemuxerStream creation and tests). Once AVStream.codec becomes
deprecated, coded size fields are not externally populated unless we
spin up a temporary ffmpeg decoder to obtain that information.

It also drops the metadata logging in OnFindStreamInfoDone for
coded_size, since that metadata is no longer different than just width
and height, which are already logged.

Note that MSE MP4 parser has always just used the width, height for
coded size in similar construction of VideoDecoderConfigs in
MP4StreamParser.  MSE mp2t and WebM stream parsers appear to populate
coded size more precisely.

BUG=591845, 665539
TEST=No media_unittests, ffmpeg_regression_tests regression under LSAN on linux
==========

to

==========
Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Anticipating AVStream.codec->coded_{width,height} will be inaccessible in
ffmpeg soon, this change uses just the width and height values as hints
of the coded size in AVStreamToVideoDecoderConfig (used only in
FFmpegDemuxerStream creation and tests). Once AVStream.codec becomes
deprecated, coded size fields are not externally populated unless we
spin up a temporary ffmpeg decoder to obtain that information.

It also drops the metadata logging in OnFindStreamInfoDone for
coded_size, since that metadata is no longer different than just width
and height, which are already logged.

Note that MSE MP4 parser has always just used the width, height for
coded size in similar construction of VideoDecoderConfigs in
MP4StreamParser.  MSE mp2t and WebM stream parsers appear to populate
coded size more precisely.

Marks VideoDecoderConfig.coded_size() and related histograms.xml
entries as deprecated.

BUG=591845, 665539
TEST=No media_unittests, ffmpeg_regression_tests regression under LSAN on linux
==========

[Steven Holte, 2016-11-15 20:08:19]

histograms lgtm

[DaleCurtis, 2016-11-15 20:31:27]

lgtm

[wolenetz, 2016-11-15 20:42:11]

The CQ bit was unchecked by wolenetz@chromium.org

[wolenetz, 2016-11-15 20:42:19]

The CQ bit was checked by wolenetz@chromium.org

[wolenetz, 2016-11-15 20:42:27]

Thanks for reviews.

[commit-bot: I haz the power, 2016-11-15 20:42:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 00:08:07]

Description was changed from

==========
Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Anticipating AVStream.codec->coded_{width,height} will be inaccessible in
ffmpeg soon, this change uses just the width and height values as hints
of the coded size in AVStreamToVideoDecoderConfig (used only in
FFmpegDemuxerStream creation and tests). Once AVStream.codec becomes
deprecated, coded size fields are not externally populated unless we
spin up a temporary ffmpeg decoder to obtain that information.

It also drops the metadata logging in OnFindStreamInfoDone for
coded_size, since that metadata is no longer different than just width
and height, which are already logged.

Note that MSE MP4 parser has always just used the width, height for
coded size in similar construction of VideoDecoderConfigs in
MP4StreamParser.  MSE mp2t and WebM stream parsers appear to populate
coded size more precisely.

Marks VideoDecoderConfig.coded_size() and related histograms.xml
entries as deprecated.

BUG=591845, 665539
TEST=No media_unittests, ffmpeg_regression_tests regression under LSAN on linux
==========

to

==========
Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Anticipating AVStream.codec->coded_{width,height} will be inaccessible in
ffmpeg soon, this change uses just the width and height values as hints
of the coded size in AVStreamToVideoDecoderConfig (used only in
FFmpegDemuxerStream creation and tests). Once AVStream.codec becomes
deprecated, coded size fields are not externally populated unless we
spin up a temporary ffmpeg decoder to obtain that information.

It also drops the metadata logging in OnFindStreamInfoDone for
coded_size, since that metadata is no longer different than just width
and height, which are already logged.

Note that MSE MP4 parser has always just used the width, height for
coded size in similar construction of VideoDecoderConfigs in
MP4StreamParser.  MSE mp2t and WebM stream parsers appear to populate
coded size more precisely.

Marks VideoDecoderConfig.coded_size() and related histograms.xml
entries as deprecated.

BUG=591845, 665539
TEST=No media_unittests, ffmpeg_regression_tests regression under LSAN on linux
==========

[commit-bot: I haz the power, 2016-11-16 00:08:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-16 00:12:10]

Description was changed from

==========
Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Anticipating AVStream.codec->coded_{width,height} will be inaccessible in
ffmpeg soon, this change uses just the width and height values as hints
of the coded size in AVStreamToVideoDecoderConfig (used only in
FFmpegDemuxerStream creation and tests). Once AVStream.codec becomes
deprecated, coded size fields are not externally populated unless we
spin up a temporary ffmpeg decoder to obtain that information.

It also drops the metadata logging in OnFindStreamInfoDone for
coded_size, since that metadata is no longer different than just width
and height, which are already logged.

Note that MSE MP4 parser has always just used the width, height for
coded size in similar construction of VideoDecoderConfigs in
MP4StreamParser.  MSE mp2t and WebM stream parsers appear to populate
coded size more precisely.

Marks VideoDecoderConfig.coded_size() and related histograms.xml
entries as deprecated.

BUG=591845, 665539
TEST=No media_unittests, ffmpeg_regression_tests regression under LSAN on linux
==========

to

==========
Use width,height for coded_{width,height} in AVStreamToVideoDecoderConfig

Anticipating AVStream.codec->coded_{width,height} will be inaccessible in
ffmpeg soon, this change uses just the width and height values as hints
of the coded size in AVStreamToVideoDecoderConfig (used only in
FFmpegDemuxerStream creation and tests). Once AVStream.codec becomes
deprecated, coded size fields are not externally populated unless we
spin up a temporary ffmpeg decoder to obtain that information.

It also drops the metadata logging in OnFindStreamInfoDone for
coded_size, since that metadata is no longer different than just width
and height, which are already logged.

Note that MSE MP4 parser has always just used the width, height for
coded size in similar construction of VideoDecoderConfigs in
MP4StreamParser.  MSE mp2t and WebM stream parsers appear to populate
coded size more precisely.

Marks VideoDecoderConfig.coded_size() and related histograms.xml
entries as deprecated.

BUG=591845, 665539
TEST=No media_unittests, ffmpeg_regression_tests regression under LSAN on linux

Committed: https://crrev.com/29241f214adfd993990b409c8f42dca858775dc9
Cr-Commit-Position: refs/heads/master@{#432300}
==========

[commit-bot: I haz the power, 2016-11-16 00:12:11]

Patchset 2 (id:??) landed as
https://crrev.com/29241f214adfd993990b409c8f42dca858775dc9
Cr-Commit-Position: refs/heads/master@{#432300}