Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 250653002: Mark some content::BrowserThread methods with WARN_UNUSED_RESULT. (Closed)

Created:
6 years, 8 months ago by Lei Zhang
Modified:
6 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Mark some content::BrowserThread methods with WARN_UNUSED_RESULT. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266282

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M content/browser/service_worker/service_worker_test_utils.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/browser_thread.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Lei Zhang
I know a guy who wrote just: BrowserThread::CurrentlyOn(BrowserThread::UI); without the DCHECK().
6 years, 8 months ago (2014-04-24 17:43:41 UTC) #1
jam
lgtm
6 years, 8 months ago (2014-04-24 17:55:26 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-24 18:07:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/250653002/1
6 years, 8 months ago (2014-04-24 21:53:29 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 23:48:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-24 23:48:11 UTC) #6
Lei Zhang
I forgot to build content_browsertests, so there is one place in a test util file ...
6 years, 8 months ago (2014-04-25 00:32:49 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-25 00:32:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/250653002/20001
6 years, 8 months ago (2014-04-25 00:34:53 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 00:38:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-25 00:38:21 UTC) #11
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-25 06:11:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/250653002/20001
6 years, 8 months ago (2014-04-25 08:22:13 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 23:25:33 UTC) #14
Message was sent while issue was closed. 
Change committed as 266282

Powered by Google App Engine
This is Rietveld 408576698