Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2506503002: Revert "Revert "JumpToFrame refactor"" + Fix (Closed)

Created:
4 years, 1 month ago by turnidge
Modified:
4 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert "JumpToFrame refactor"" + Fix This reverts commit 1cdb3d215593844599b78c55729228dede63e651. I have also added in a fix for the lazy-deopt in exception handler case. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/2d22e85cf009d52833cf8608c68cbd1e91ec72ce

Patch Set 1 #

Patch Set 2 : new client #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -154 lines) Patch
M runtime/vm/exceptions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/exceptions.cc View 1 4 chunks +31 lines, -19 lines 0 comments Download
M runtime/vm/profiler.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M runtime/vm/simulator_arm.h View 1 chunk +1 line, -6 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 2 chunks +1 line, -10 lines 0 comments Download
M runtime/vm/simulator_arm64.h View 1 chunk +1 line, -6 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 2 chunks +1 line, -10 lines 0 comments Download
M runtime/vm/simulator_dbc.h View 1 chunk +1 line, -6 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 2 chunks +15 lines, -10 lines 0 comments Download
M runtime/vm/simulator_mips.h View 1 chunk +1 line, -6 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 2 chunks +1 line, -10 lines 0 comments Download
M runtime/vm/stub_code.h View 3 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/stub_code.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 2 chunks +25 lines, -8 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 2 chunks +25 lines, -8 lines 0 comments Download
M runtime/vm/stub_code_dbc.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 2 chunks +27 lines, -10 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 2 chunks +28 lines, -11 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 2 chunks +29 lines, -21 lines 0 comments Download
M runtime/vm/thread.h View 2 chunks +21 lines, -0 lines 0 comments Download
M runtime/vm/thread.cc View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
turnidge
4 years, 1 month ago (2016-11-15 01:00:27 UTC) #2
Cutch
lgtm
4 years, 1 month ago (2016-11-15 01:01:47 UTC) #3
turnidge
4 years, 1 month ago (2016-11-21 16:49:25 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
2d22e85cf009d52833cf8608c68cbd1e91ec72ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698