Continue nit cleanup in fwl/core

Continue nit cleanup in fwl/core

Committed: https://pdfium.googlesource.com/pdfium/+/92549cd7502296328aecef23dab6d7fc0e847645

[dsinclair, 2016-11-15 21:38:57]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 21:39:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-11-15 21:39:10]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-15 21:39:10]

PTAL.

[Tom Sepez, 2016-11-15 22:29:29]

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/cfwl_widget.h
File xfa/fwl/core/cfwl_widget.h (right):

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/cfwl_widge...
xfa/fwl/core/cfwl_widget.h:27: const IFWL_Widget* GetWidget() const { return
m_pIface.get(); }
I don't think we need both, since its a pointer and not part of |this|, if we
just have:

  
IFWL_Widget* GetWidget() const { return m_pIface.get(); }

[npm, 2016-11-15 23:27:03]

looks good

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/cfwl_listb...
File xfa/fwl/core/cfwl_listbox.cpp (right):

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/cfwl_listb...
xfa/fwl/core/cfwl_listbox.cpp:53: if (iSel < 0)
Remove this if: unneeded.

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/fwl_noteim...
File xfa/fwl/core/fwl_noteimp.cpp (left):

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/fwl_noteim...
xfa/fwl/core/fwl_noteimp.cpp:261: if (bRet) {
Maybe if (bRet && ...

[dsinclair, 2016-11-16 15:10:47]

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/cfwl_listb...
File xfa/fwl/core/cfwl_listbox.cpp (right):

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/cfwl_listb...
xfa/fwl/core/cfwl_listbox.cpp:53: if (iSel < 0)
On 2016/11/15 23:27:03, npm wrote:
> Remove this if: unneeded.

Done.

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/cfwl_widget.h
File xfa/fwl/core/cfwl_widget.h (right):

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/cfwl_widge...
xfa/fwl/core/cfwl_widget.h:27: const IFWL_Widget* GetWidget() const { return
m_pIface.get(); }
On 2016/11/15 22:29:29, Tom Sepez wrote:
> I don't think we need both, since its a pointer and not part of |this|, if we
> just have:
> 
>   
> IFWL_Widget* GetWidget() const { return m_pIface.get(); }

Done.

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/fwl_noteim...
File xfa/fwl/core/fwl_noteimp.cpp (left):

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/fwl_noteim...
xfa/fwl/core/fwl_noteimp.cpp:261: if (bRet) {
On 2016/11/15 23:27:03, npm wrote:
> Maybe if (bRet && ...

Acknowledged.

[npm, 2016-11-16 15:15:15]

lgtm

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/fwl_noteim...
File xfa/fwl/core/fwl_noteimp.cpp (right):

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/fwl_noteim...
xfa/fwl/core/fwl_noteimp.cpp:319: if (m_pFocus) {
Let's just pretend I meant the if ( && comment here

[dsinclair, 2016-11-16 15:19:41]

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/fwl_noteim...
File xfa/fwl/core/fwl_noteimp.cpp (right):

https://codereview.chromium.org/2506493003/diff/40001/xfa/fwl/core/fwl_noteim...
xfa/fwl/core/fwl_noteimp.cpp:319: if (m_pFocus) {
On 2016/11/16 15:15:15, npm wrote:
> Let's just pretend I meant the if ( && comment here

Done.

[dsinclair, 2016-11-16 15:19:45]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-16 15:19:45]

The patchset sent to the CQ was uploaded after l-g-t-m from npm@chromium.org
Link to the patchset: https://codereview.chromium.org/2506493003/#ps70001
(title: "review feedback")

[commit-bot: I haz the power, 2016-11-16 15:19:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 15:32:51]

Description was changed from

==========
Continue nit cleanup in fwl/core
==========

to

==========
Continue nit cleanup in fwl/core

Committed:
https://pdfium.googlesource.com/pdfium/+/92549cd7502296328aecef23dab6d7fc0e84...
==========

[commit-bot: I haz the power, 2016-11-16 15:32:52]

Committed patchset #5 (id:70001) as
https://pdfium.googlesource.com/pdfium/+/92549cd7502296328aecef23dab6d7fc0e84...