Add a switch for tablet power button behavior

Add a switch for tablet power button behavior

Major tablet power button behavior feature is landed in M56. However, it still has several unsolved issues. Add a switch for tablet power button behavior. It is not enabled for M56.

BUG=665225
TEST=manual test and automate tests

Committed: https://crrev.com/9cbb0b1f01687665a716a8797243723fab7bf71d
Cr-Commit-Position: refs/heads/master@{#432214}

[Qiang(Joe) Xu, 2016-11-15 00:31:15]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 00:33:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Qiang(Joe) Xu, 2016-11-15 00:36:41]

Description was changed from

==========
Add a switch for tablet power button behavior

BUG=665225
==========

to

==========
Add a switch for tablet power button behavior

Major tablet power button behavior feature is landed in M56. However, it still
has several unsolved issues. Add a switch for tablet power button behavior. It
is not enabled for M56.

BUG=665225
TEST=manual test and automate tests
==========

[Qiang(Joe) Xu, 2016-11-15 00:36:41]

warx@chromium.org changed reviewers:
+ derat@chromium.org

[Qiang(Joe) Xu, 2016-11-15 00:38:02]

Hi Daniel, could you ptal? Thanks!

https://codereview.chromium.org/2506493002/diff/1/ash/common/ash_switches.h
File ash/common/ash_switches.h (left):

https://codereview.chromium.org/2506493002/diff/1/ash/common/ash_switches.h#o...
ash/common/ash_switches.h:35: ASH_EXPORT extern const char
kAshEnableUnifiedDesktop[];
find it is not used anywhere...

[commit-bot: I haz the power, 2016-11-15 02:23:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 02:23:53]

Dry run: This issue passed the CQ dry run.

[Daniel Erat, 2016-11-15 15:10:43]

lgtm after one comment is addressed

https://codereview.chromium.org/2506493002/diff/1/ash/common/ash_switches.cc
File ash/common/ash_switches.cc (right):

https://codereview.chromium.org/2506493002/diff/1/ash/common/ash_switches.cc#...
ash/common/ash_switches.cc:67: const char kAshEnableTabletPowerButton[] =
"enable-tablet-power-button";
this should probably be ash-enable-tablet-power-button to match most other ash
switches, right? (i don't know why enable-touchview doesn't have the same
prefix.)

[Qiang(Joe) Xu, 2016-11-15 17:29:09]

https://codereview.chromium.org/2506493002/diff/1/ash/common/ash_switches.cc
File ash/common/ash_switches.cc (right):

https://codereview.chromium.org/2506493002/diff/1/ash/common/ash_switches.cc#...
ash/common/ash_switches.cc:67: const char kAshEnableTabletPowerButton[] =
"enable-tablet-power-button";
On 2016/11/15 15:10:42, Daniel Erat wrote:
> this should probably be ash-enable-tablet-power-button to match most other ash
> switches, right? (i don't know why enable-touchview doesn't have the same
> prefix.)

yes.. changed.
I didn't change enable-touchview in this CL (it needs to match the chromeos
platform code).

[Qiang(Joe) Xu, 2016-11-15 17:29:23]

The CQ bit was checked by warx@chromium.org

[Qiang(Joe) Xu, 2016-11-15 17:29:24]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2506493002/#ps20001
(title: "based on comments")

[commit-bot: I haz the power, 2016-11-15 17:29:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 18:05:00]

Description was changed from

==========
Add a switch for tablet power button behavior

Major tablet power button behavior feature is landed in M56. However, it still
has several unsolved issues. Add a switch for tablet power button behavior. It
is not enabled for M56.

BUG=665225
TEST=manual test and automate tests
==========

to

==========
Add a switch for tablet power button behavior

Major tablet power button behavior feature is landed in M56. However, it still
has several unsolved issues. Add a switch for tablet power button behavior. It
is not enabled for M56.

BUG=665225
TEST=manual test and automate tests
==========

[commit-bot: I haz the power, 2016-11-15 18:05:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-15 18:33:38]

Description was changed from

==========
Add a switch for tablet power button behavior

Major tablet power button behavior feature is landed in M56. However, it still
has several unsolved issues. Add a switch for tablet power button behavior. It
is not enabled for M56.

BUG=665225
TEST=manual test and automate tests
==========

to

==========
Add a switch for tablet power button behavior

Major tablet power button behavior feature is landed in M56. However, it still
has several unsolved issues. Add a switch for tablet power button behavior. It
is not enabled for M56.

BUG=665225
TEST=manual test and automate tests

Committed: https://crrev.com/9cbb0b1f01687665a716a8797243723fab7bf71d
Cr-Commit-Position: refs/heads/master@{#432214}
==========

[commit-bot: I haz the power, 2016-11-15 18:33:39]

Patchset 2 (id:??) landed as
https://crrev.com/9cbb0b1f01687665a716a8797243723fab7bf71d
Cr-Commit-Position: refs/heads/master@{#432214}