Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2506463003: [Extensions] Don't show the pending URL for chrome.tabs API navigations (Closed)

Created:
4 years, 1 month ago by Devlin
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Extensions] Don't show the pending URL for chrome.tabs API navigations For the pdf extension, treat navigations as renderer-initiated. Ideally, we want this to become default for all extensions, but that risks breakage. Based on creis@'s patch at https://codereview.chromium.org/2475033002/. BUG=660498 TEST=See bug for repro steps. Review-Url: https://codereview.chromium.org/2492863003 Cr-Commit-Position: refs/heads/master@{#431726} (cherry picked from commit 2097de33a1f3d04e78d93e9e2f16aad4b97e47d7) Committed: https://chromium.googlesource.com/chromium/src/+/50cfe8d0926f013a794afe49e39cc48fe2e3848b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -4 lines) Patch
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +16 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api_unittest.cc View 3 chunks +53 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_test.cc View 3 chunks +31 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/tabs/pdf_extension_test.html View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Devlin
4 years, 1 month ago (2016-11-15 15:01:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
50cfe8d0926f013a794afe49e39cc48fe2e3848b.

Powered by Google App Engine
This is Rietveld 408576698