Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: content/public/common/push_messaging_status.h

Issue 2506393003: Add a timeout to push message processing. (Closed)
Patch Set: typo Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/push_messaging_status.h
diff --git a/content/public/common/push_messaging_status.h b/content/public/common/push_messaging_status.h
index 8b9fb0a32ba79750e4a296e6fd62960e9bc159d7..d164f38861a775ba4c846ed859e08e41f7b36731 100644
--- a/content/public/common/push_messaging_status.h
+++ b/content/public/common/push_messaging_status.h
@@ -186,12 +186,15 @@ enum PushDeliveryStatus {
// event.waitUntil that got rejected.
PUSH_DELIVERY_STATUS_EVENT_WAITUNTIL_REJECTED = 6,
+ // The message was delivered, but the Service Worker timed out processing it.
+ PUSH_DELIVERY_STATUS_TIMEOUT = 7,
Peter Beverloo 2016/11/28 10:33:54 you need to update histograms.xml
harkness 2016/11/28 15:33:01 Thanks! I forgot that.
+
// NOTE: Do not renumber these as that would confuse interpretation of
// previously logged data. When making changes, also update the enum list
// in tools/metrics/histograms/histograms.xml to keep it in sync, and
// update PUSH_DELIVERY_STATUS_LAST below.
- PUSH_DELIVERY_STATUS_LAST = PUSH_DELIVERY_STATUS_EVENT_WAITUNTIL_REJECTED
+ PUSH_DELIVERY_STATUS_LAST = PUSH_DELIVERY_STATUS_TIMEOUT
};
// Push message user visible tracking for reporting in UMA. Enum values can be

Powered by Google App Engine
This is Rietveld 408576698