Add a timeout to push message processing.

Add a timeout to push message processing.

Currently, the only time limitation on push message processing is the
service worker default timeout of 5 minutes. 99% of push messages are
processed in under 1 minute, so we want to reduce the timeout so that
outliers don't begin to rely on the long processing available.

BUG=646783
Committed: https://crrev.com/0046294f2f1c6a3b72dd6d373a8530e1a7a296ec
Cr-Commit-Position: refs/heads/master@{#434995}

[harkness, 2016-11-18 10:33:23]

harkness@chromium.org changed reviewers:
+ peter@chromium.org

[harkness, 2016-11-18 10:33:31]

The CQ bit was checked by harkness@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 10:33:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 11:58:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 11:58:07]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[harkness, 2016-11-21 12:51:52]

The CQ bit was checked by harkness@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 12:52:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 13:59:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 13:59:04]

Dry run: This issue passed the CQ dry run.

[Peter Beverloo, 2016-11-28 10:33:54]

lgtm % histogram update

https://codereview.chromium.org/2506393003/diff/20001/content/browser/push_me...
File content/browser/push_messaging/push_messaging_router.cc (right):

https://codereview.chromium.org/2506393003/diff/20001/content/browser/push_me...
content/browser/push_messaging/push_messaging_router.cc:25: // The number of
seconds for which a push message should be allowed to run.
nit: it's the event that runs

https://codereview.chromium.org/2506393003/diff/20001/content/public/common/p...
File content/public/common/push_messaging_status.h (right):

https://codereview.chromium.org/2506393003/diff/20001/content/public/common/p...
content/public/common/push_messaging_status.h:190: PUSH_DELIVERY_STATUS_TIMEOUT
= 7,
you need to update histograms.xml

[harkness, 2016-11-28 15:33:01]

https://codereview.chromium.org/2506393003/diff/20001/content/browser/push_me...
File content/browser/push_messaging/push_messaging_router.cc (right):

https://codereview.chromium.org/2506393003/diff/20001/content/browser/push_me...
content/browser/push_messaging/push_messaging_router.cc:25: // The number of
seconds for which a push message should be allowed to run.
On 2016/11/28 10:33:54, Peter Beverloo wrote:
> nit: it's the event that runs

Done.

https://codereview.chromium.org/2506393003/diff/20001/content/public/common/p...
File content/public/common/push_messaging_status.h (right):

https://codereview.chromium.org/2506393003/diff/20001/content/public/common/p...
content/public/common/push_messaging_status.h:190: PUSH_DELIVERY_STATUS_TIMEOUT
= 7,
On 2016/11/28 10:33:54, Peter Beverloo wrote:
> you need to update histograms.xml

Thanks! I forgot that.

[harkness, 2016-11-28 15:44:29]

harkness@chromium.org changed reviewers:
+ asvitkine@chromium.org, avi@chromium.org

[harkness, 2016-11-28 15:44:30]

avi@chromium.org: Please review changes in
content/public/common/push_messaging_status.h.

asvitkine@chromium.org: Please review changes in
tools/metrics/histograms/histograms.xml.

Thanks!
Jen

[Alexei Svitkine (slow), 2016-11-28 15:47:28]

lgtm

[Avi (use Gerrit), 2016-11-28 18:08:42]

lgtm

nice

[harkness, 2016-11-29 10:26:41]

The CQ bit was checked by harkness@chromium.org

[harkness, 2016-11-29 10:26:42]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2506393003/#ps40001
(title: "Updated comment and added entry in histograms.xml")

[commit-bot: I haz the power, 2016-11-29 10:27:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 12:17:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 12:17:47]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[harkness, 2016-11-29 14:34:47]

The CQ bit was checked by harkness@chromium.org

[commit-bot: I haz the power, 2016-11-29 14:35:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 15:26:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480430087526950,
"parent_rev": "0032ac271890337ec866969382744b4219296bc5", "commit_rev":
"482c479b488cc67845d1139f83f0f32b3fdd8dbe"}

[commit-bot: I haz the power, 2016-11-29 15:26:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-29 15:29:17]

Description was changed from

==========
Add a timeout to push message processing.

Currently, the only time limitation on push message processing is the
service worker default timeout of 5 minutes. 99% of push messages are
processed in under 1 minute, so we want to reduce the timeout so that
outliers don't begin to rely on the long processing available.

BUG=646783
==========

to

==========
Add a timeout to push message processing.

Currently, the only time limitation on push message processing is the
service worker default timeout of 5 minutes. 99% of push messages are
processed in under 1 minute, so we want to reduce the timeout so that
outliers don't begin to rely on the long processing available.

BUG=646783

Committed: https://crrev.com/0046294f2f1c6a3b72dd6d373a8530e1a7a296ec
Cr-Commit-Position: refs/heads/master@{#434995}
==========

[commit-bot: I haz the power, 2016-11-29 15:29:18]

Patchset 3 (id:??) landed as
https://crrev.com/0046294f2f1c6a3b72dd6d373a8530e1a7a296ec
Cr-Commit-Position: refs/heads/master@{#434995}