Enhance precision of recorded instantiation info in ResolutionWorldBuilder

Enhance precision of recorded instantiation info in ResolutionWorldBuilder

+ use this to enhance closed_world_test.

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/39697dc5cf3e10c8f78aff48cf99ac57963b98ba

[Johnni Winther, 2016-11-17 11:29:04]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-11-18 00:11:35]

lgtm

https://codereview.chromium.org/2506393002/diff/20001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/world_builder.dart (right):

https://codereview.chromium.org/2506393002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_builder.dart:186: /// The type and kind of a
register instantiation.
what do you mean by "register instantiation"?

https://codereview.chromium.org/2506393002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_builder.dart:247: ///    }
consider also giving an example of a class that is instantiated "abstractly"

https://codereview.chromium.org/2506393002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_builder.dart:257: instantiationMap ??= new
Maplet<ConstructorElement, Set<Instance>>();
are maplets still better than maps? I think there have been optimizations for
maps in the vm where if they are small (< 16 keys) they are represented as
lists. same for setlets

https://codereview.chromium.org/2506393002/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/serialization/model_test_helper.dart (right):

https://codereview.chromium.org/2506393002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/serialization/model_test_helper.dart:125: /// Normal the
instantiation map by removing redirections and converting
Normal -> Normalize

[Johnni Winther, 2016-11-18 09:52:49]

https://codereview.chromium.org/2506393002/diff/20001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/world_builder.dart (right):

https://codereview.chromium.org/2506393002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_builder.dart:186: /// The type and kind of a
register instantiation.
On 2016/11/18 00:11:35, Harry Terkelsen wrote:
> what do you mean by "register instantiation"?

register -> registered

https://codereview.chromium.org/2506393002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_builder.dart:247: ///    }
On 2016/11/18 00:11:35, Harry Terkelsen wrote:
> consider also giving an example of a class that is instantiated "abstractly"

Done.

https://codereview.chromium.org/2506393002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_builder.dart:257: instantiationMap ??= new
Maplet<ConstructorElement, Set<Instance>>();
On 2016/11/18 00:11:35, Harry Terkelsen wrote:
> are maplets still better than maps? I think there have been optimizations for
> maps in the vm where if they are small (< 16 keys) they are represented as
> lists. same for setlets

Changed.

https://codereview.chromium.org/2506393002/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/serialization/model_test_helper.dart (right):

https://codereview.chromium.org/2506393002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/serialization/model_test_helper.dart:125: /// Normal the
instantiation map by removing redirections and converting
On 2016/11/18 00:11:35, Harry Terkelsen wrote:
> Normal -> Normalize

Done.

[Johnni Winther, 2016-11-18 09:57:40]

Description was changed from

==========
Enhance precision of recorded instantiation info in ResolutionWorldBuilder

+ use this to enhance closed_world_test.
==========

to

==========
Enhance precision of recorded instantiation info in ResolutionWorldBuilder

+ use this to enhance closed_world_test.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/39697dc5cf3e10c8f78aff48cf99ac57963b98ba
==========

[Johnni Winther, 2016-11-18 09:57:42]

Committed patchset #3 (id:40001) manually as
39697dc5cf3e10c8f78aff48cf99ac57963b98ba (presubmit successful).