Mojo: adding a thread safe associated interface ptr.

Generalizing ThreadSafeInterfacePtr class so that it can be
specialized to support InterfacePtr and AssociatedInterfacePtr.

BUG=666222
Committed: https://crrev.com/813fe9380b32017f9187b9fb1172354bd2763d65
Cr-Commit-Position: refs/heads/master@{#433056}

[Jay Civelli, 2016-11-17 08:26:23]

Description was changed from

==========
Mojo: adding a thread safe associated interface ptr.

Refactoring the ThreadSafeInterfacePtr class into a base class that is
used in the new ThreadSafeAssociatedInterfacePtr class that lets
callers invoke methods from any threads.

BUG=666222
==========

to

==========
Mojo: adding a thread safe associated interface ptr.

Refactoring the ThreadSafeInterfacePtr class into a base class that is
used in the new ThreadSafeAssociatedInterfacePtr class that lets
callers invoke methods from any threads.

BUG=666222
==========

[Jay Civelli, 2016-11-17 08:26:23]

jcivelli@chromium.org changed reviewers:
+ yzshen@chromium.org

[Jay Civelli, 2016-11-17 16:34:33]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 16:34:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 16:39:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 16:39:39]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Jay Civelli, 2016-11-17 16:52:01]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 16:52:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-11-17 17:58:12]

https://codereview.chromium.org/2506383002/diff/20001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/thread_safe_associated_interface_ptr.h (right):

https://codereview.chromium.org/2506383002/diff/20001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/thread_safe_associated_interface_ptr.h:41: class
ThreadSafeAssociatedInterfacePtr :
It seems this code is the same as ThreadSafeInterfacePtr. Does it make sense to
add a template template parameter to ThreadSafeInterfacePtrBase, so that:


tempalte <typename Interface, template<typename> typename InterfacePtrType>
class ThreadSafeInterfacePtrBase { ... };

template <typename Interface>
using ThreadSafeAssociatedInterfacePtr = ThreadSafeInterfaceBase<Interface,
AssociatedIntefacePtr>;

template <typename Interface>
using ThreadSafeInterfacePtr = ThreadSafeInterfaceBase<Interface, IntefacePtr>;

[commit-bot: I haz the power, 2016-11-17 18:36:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 18:36:49]

Dry run: This issue passed the CQ dry run.

[Jay Civelli, 2016-11-17 19:16:20]

https://codereview.chromium.org/2506383002/diff/20001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/thread_safe_associated_interface_ptr.h (right):

https://codereview.chromium.org/2506383002/diff/20001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/thread_safe_associated_interface_ptr.h:41: class
ThreadSafeAssociatedInterfacePtr :
On 2016/11/17 17:58:12, yzshen1 wrote:
> It seems this code is the same as ThreadSafeInterfacePtr. Does it make sense
to
> add a template template parameter to ThreadSafeInterfacePtrBase, so that:
> 
> 
> tempalte <typename Interface, template<typename> typename InterfacePtrType>
> class ThreadSafeInterfacePtrBase { ... };
> 
> template <typename Interface>
> using ThreadSafeAssociatedInterfacePtr = ThreadSafeInterfaceBase<Interface,
> AssociatedIntefacePtr>;
> 
> template <typename Interface>
> using ThreadSafeInterfacePtr = ThreadSafeInterfaceBase<Interface,
IntefacePtr>;

Oh, that's nice! My template fu was not that good that I thought of doing that.
Done.

[Jay Civelli, 2016-11-17 19:16:36]

The CQ bit was checked by jcivelli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 19:17:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-11-17 19:21:41]

LGTM

Thanks!

https://codereview.chromium.org/2506383002/diff/60001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/thread_safe_interface_ptr.h (right):

https://codereview.chromium.org/2506383002/diff/60001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/thread_safe_interface_ptr.h:52: LOG(ERROR) <<
"Attempting to create a ThreadSafeInterfacePtr from an "
nit: maybe change the comment slightly:
ThreadSafeInterfacePtr -> "ThreadSafe[Associated]InterfacePtr" 
InterfacePtr -> "[Associated]InterfacePtr"

[Jay Civelli, 2016-11-17 19:29:08]

Description was changed from

==========
Mojo: adding a thread safe associated interface ptr.

Refactoring the ThreadSafeInterfacePtr class into a base class that is
used in the new ThreadSafeAssociatedInterfacePtr class that lets
callers invoke methods from any threads.

BUG=666222
==========

to

==========
Generalizing ThreadSafeInterfacePtr class so that it can be
specialized to support InterfacePtr and AssociatedInterfacePtr.

BUG=666222
==========

[Jay Civelli, 2016-11-17 19:29:20]

https://codereview.chromium.org/2506383002/diff/60001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/thread_safe_interface_ptr.h (right):

https://codereview.chromium.org/2506383002/diff/60001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/thread_safe_interface_ptr.h:52: LOG(ERROR) <<
"Attempting to create a ThreadSafeInterfacePtr from an "
On 2016/11/17 19:21:41, yzshen1 wrote:
> nit: maybe change the comment slightly:
> ThreadSafeInterfacePtr -> "ThreadSafe[Associated]InterfacePtr" 
> InterfacePtr -> "[Associated]InterfacePtr"

Done.

[Jay Civelli, 2016-11-17 19:29:27]

The CQ bit was checked by jcivelli@chromium.org

[Jay Civelli, 2016-11-17 19:29:28]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2506383002/#ps80001
(title: "Addressed comment + sync")

[commit-bot: I haz the power, 2016-11-17 19:30:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 20:41:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 20:41:12]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jay Civelli, 2016-11-17 20:56:13]

The CQ bit was checked by jcivelli@chromium.org

[commit-bot: I haz the power, 2016-11-17 20:57:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 00:07:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 00:07:23]

Failed to apply the patch.

[Jay Civelli, 2016-11-18 00:14:25]

The CQ bit was checked by jcivelli@chromium.org

[commit-bot: I haz the power, 2016-11-18 00:15:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 00:42:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 00:42:53]

Failed to apply the patch.

[Jay Civelli, 2016-11-18 02:03:05]

The CQ bit was checked by jcivelli@chromium.org

[commit-bot: I haz the power, 2016-11-18 02:06:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 03:23:12]

Description was changed from

==========
Generalizing ThreadSafeInterfacePtr class so that it can be
specialized to support InterfacePtr and AssociatedInterfacePtr.

BUG=666222
==========

to

==========
Generalizing ThreadSafeInterfacePtr class so that it can be
specialized to support InterfacePtr and AssociatedInterfacePtr.

BUG=666222
==========

[commit-bot: I haz the power, 2016-11-18 03:23:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-18 03:25:31]

Description was changed from

==========
Generalizing ThreadSafeInterfacePtr class so that it can be
specialized to support InterfacePtr and AssociatedInterfacePtr.

BUG=666222
==========

to

==========
Generalizing ThreadSafeInterfacePtr class so that it can be
specialized to support InterfacePtr and AssociatedInterfacePtr.

BUG=666222

Committed: https://crrev.com/813fe9380b32017f9187b9fb1172354bd2763d65
Cr-Commit-Position: refs/heads/master@{#433056}
==========

[commit-bot: I haz the power, 2016-11-18 03:25:32]

Patchset 5 (id:??) landed as
https://crrev.com/813fe9380b32017f9187b9fb1172354bd2763d65
Cr-Commit-Position: refs/heads/master@{#433056}