Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2506373005: reduce setting wallpaper latency. (Closed)

Created:
4 years, 1 month ago by Muyuan
Modified:
4 years, 1 month ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, hidehiko+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, lhchavez+watch_chromium.org, oshima+watch_chromium.org, darin (slow to review), davemoore+watch_chromium.org, qsr+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reduce setting wallpaper latency. Previously, setting the wallpaper is slow because there are multiple decoding / encoding (esp png) involved. This CL asks ImageDecoder to do a more general decoding based on the bytes from Arc and thus, Android does not need to do decoding and encoding anymore. Test=Set large wallpaper becomes faster. Bug=666974 Committed: https://crrev.com/8e4822ebbb9b4108013d9246974b228cb52834f3 Cr-Commit-Position: refs/heads/master@{#433692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/arc/common/wallpaper.mojom View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Muyuan
4 years, 1 month ago (2016-11-19 00:22:29 UTC) #2
Luis Héctor Chávez
lgtm (adding dcheng@ for the .mojom change)
4 years, 1 month ago (2016-11-21 17:22:52 UTC) #4
dcheng
rs lgtm
4 years, 1 month ago (2016-11-21 22:22:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506373005/1
4 years, 1 month ago (2016-11-21 22:38:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 23:33:53 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 23:38:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e4822ebbb9b4108013d9246974b228cb52834f3
Cr-Commit-Position: refs/heads/master@{#433692}

Powered by Google App Engine
This is Rietveld 408576698