Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2506363004: V4L2VDA: fix starting the device poll thread twice. (Closed)

Created:
4 years, 1 month ago by wuchengli
Modified:
4 years, 1 month ago
Reviewers:
kcwu, Pawel Osciak
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

V4L2VDA: fix starting the device poll thread twice. Starting the thread twice happened in the following steps. (1) V4L2VDA gets a Flush. (2) Before Flush is done, V4L2VDA gets a Reset. This patch checks if the device poll thread is started before starting it in ResetDoneTask. BUG=chrome-os-partner:59921 BUG=chromium:664112 TEST=Scroll in Android Twitter app. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6a904bfb30b37705209bb2d5e1b9cc3b079319b3 Cr-Commit-Position: refs/heads/master@{#432853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M media/gpu/v4l2_video_decode_accelerator.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
wuchengli
PTAL
4 years, 1 month ago (2016-11-17 08:18:49 UTC) #3
kcwu
lgtm
4 years, 1 month ago (2016-11-17 08:31:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506363004/1
4 years, 1 month ago (2016-11-17 12:16:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 13:11:04 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 13:15:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a904bfb30b37705209bb2d5e1b9cc3b079319b3
Cr-Commit-Position: refs/heads/master@{#432853}

Powered by Google App Engine
This is Rietveld 408576698