Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4984)

Unified Diff: chrome/gpu/arc_gpu_video_decode_accelerator.cc

Issue 2506363003: Add Media.ArcGpuVideoDecodeAccelerator.InitializeResult to histograms (Closed)
Patch Set: Add Media.ArcGpuVideoDecodeAccelerator.InitializeSuccess to histograms Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/gpu/arc_gpu_video_decode_accelerator.cc
diff --git a/chrome/gpu/arc_gpu_video_decode_accelerator.cc b/chrome/gpu/arc_gpu_video_decode_accelerator.cc
index 7b66321fd3a239e3ab835dc5d71dc2c349d43a02..77248e10ee31a809a54fe6313c3839d9f25e0561 100644
--- a/chrome/gpu/arc_gpu_video_decode_accelerator.cc
+++ b/chrome/gpu/arc_gpu_video_decode_accelerator.cc
@@ -6,6 +6,7 @@
#include "base/callback_helpers.h"
#include "base/logging.h"
+#include "base/metrics/histogram_macros.h"
#include "base/numerics/safe_math.h"
#include "base/run_loop.h"
#include "media/base/video_frame.h"
@@ -70,6 +71,15 @@ ArcGpuVideoDecodeAccelerator::~ArcGpuVideoDecodeAccelerator() {
ArcVideoAccelerator::Result ArcGpuVideoDecodeAccelerator::Initialize(
const Config& config,
ArcVideoAccelerator::Client* client) {
+ auto result = InitializeTask(config, client);
+ UMA_HISTOGRAM_BOOLEAN("Media.ArcGpuVideoDecodeAccelerator.InitializeSuccess",
+ result == SUCCESS);
Pawel Osciak 2016/11/21 09:02:37 Should we instead record the full result status en
johnylin1 2016/11/21 15:39:58 Sounds good. Done.
+ return result;
+}
+
+ArcVideoAccelerator::Result ArcGpuVideoDecodeAccelerator::InitializeTask(
+ const Config& config,
+ ArcVideoAccelerator::Client* client) {
DVLOG(5) << "Initialize(device=" << config.device_type
<< ", input_pixel_format=" << config.input_pixel_format
<< ", num_input_buffers=" << config.num_input_buffers << ")";

Powered by Google App Engine
This is Rietveld 408576698