Add Media.ArcGpuVideoDecodeAccelerator.InitializeResult to histograms

chrome/gpu/arc_gpu_video_decode_accelerator.cc

Index: chrome/gpu/arc_gpu_video_decode_accelerator.cc
diff --git a/chrome/gpu/arc_gpu_video_decode_accelerator.cc b/chrome/gpu/arc_gpu_video_decode_accelerator.cc
index 7b66321fd3a239e3ab835dc5d71dc2c349d43a02..e42c916bae8c2259f07b1d161aab245a515269dc 100644
--- a/chrome/gpu/arc_gpu_video_decode_accelerator.cc
+++ b/chrome/gpu/arc_gpu_video_decode_accelerator.cc
@@ -6,6 +6,7 @@
 
 #include "base/callback_helpers.h"
 #include "base/logging.h"
+#include "base/metrics/histogram_macros.h"
 #include "base/numerics/safe_math.h"
 #include "base/run_loop.h"
 #include "media/base/video_frame.h"
@@ -70,6 +71,15 @@ ArcGpuVideoDecodeAccelerator::~ArcGpuVideoDecodeAccelerator() {
 ArcVideoAccelerator::Result ArcGpuVideoDecodeAccelerator::Initialize(
     const Config& config,
     ArcVideoAccelerator::Client* client) {
+  ArcVideoAccelerator::Result result = InitializeTask(config, client);

[Owen Lin, 2016/11/17 08:28:28]

auto result = ?

[johnylin1, 2016/11/18 03:26:32]

Done.

+  UMA_HISTOGRAM_BOOLEAN("Media.ArcGpuVideoDecodeAccelerator.InitializeSuccess",
+                        result == SUCCESS);
+  return result;
+}
+
+ArcVideoAccelerator::Result ArcGpuVideoDecodeAccelerator::InitializeTask(

[Pawel Osciak, 2016/11/17 08:45:31]

Do we need a separate method?

[johnylin1, 2016/11/17 09:47:48]

I also wondered if the separate is good or bad. Since we also want to record
(result != SUCCESS) case, in original Initialize(), we need to add
"UMA_HISTOGRAM_BOOLEAN(..., false)" before every "return NON-SUCCESS". I worried
that would be kind of code redundant.

+    const Config& config,
+    ArcVideoAccelerator::Client* client) {
   DVLOG(5) << "Initialize(device=" << config.device_type
            << ", input_pixel_format=" << config.input_pixel_format
            << ", num_input_buffers=" << config.num_input_buffers << ")";