third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp - Issue 2506353002: Incrementally build main thread scrolling reasons [spv2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

Issue 2506353002: Incrementally build main thread scrolling reasons [spv2] (Closed)

Patch Set: Cleanup comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp ('K') | « third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp » ('j') | third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

index 50dbc35122b1cbacc90d1971bad4da37e9a16689..cf4c7aca63cf70d0af6e2030b56cf273393f4c37 100644

--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp

@@ -629,7 +629,7 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees, OneScrollNode) {

FloatPoint3D());

RefPtr<ScrollPaintPropertyNode> scroll = ScrollPaintPropertyNode::create(

ScrollPaintPropertyNode::root(), scrollTranslation, IntSize(11, 13),

- IntSize(27, 31), true, false);

+ IntSize(27, 31), true, false, false, false);

TestPaintArtifact artifact;

artifact

@@ -671,16 +671,14 @@ TEST_F(PaintArtifactCompositorTestWithPropertyTrees, NestedScrollNodes) {

TransformationMatrix().translate(11, 13), FloatPoint3D());

RefPtr<ScrollPaintPropertyNode> scrollA = ScrollPaintPropertyNode::create(

ScrollPaintPropertyNode::root(), scrollTranslationA, IntSize(2, 3),

- IntSize(5, 7), false, true);

- scrollA->addMainThreadScrollingReasons(

- MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects);

+ IntSize(5, 7), false, true, false, true);

RefPtr<TransformPaintPropertyNode> scrollTranslationB =

TransformPaintPropertyNode::create(

scrollTranslationA, TransformationMatrix().translate(37, 41),

FloatPoint3D());

RefPtr<ScrollPaintPropertyNode> scrollB = ScrollPaintPropertyNode::create(

scrollA, scrollTranslationB, IntSize(19, 23), IntSize(29, 31), true,

- false);

+ false, false, false);

TestPaintArtifact artifact;

artifact

.chunk(scrollTranslationA, ClipPaintPropertyNode::root(), effect, scrollA)