Incrementally build main thread scrolling reasons [spv2]

third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutTreeAsText.h"
 #include "core/layout/api/LayoutViewItem.h"
 #include "core/paint/ObjectPaintProperties.h"
 #include "core/paint/PaintPropertyTreePrinter.h"
 #include "platform/graphics/paint/GeometryMapper.h"
@@ skipping 2588 matching lines @@
       "  }"
       "  .forceScroll {"
       "    height: 4000px;"
       "  }"
       "</style>"
       "<div id='overflowA'>"
       "  <div class='forceScroll'></div>"
       "</div>"
       "<div class='forceScroll'></div>");
   Element* overflowA = document().getElementById("overflowA");
-  EXPECT_FALSE(frameScroll()->hasMainThreadScrollingReasons(
-      MainThreadScrollingReason::kThreadedScrollingDisabled));
+  EXPECT_FALSE(frameScroll()->threadedScrollingDisabled());
   EXPECT_FALSE(overflowA->layoutObject()
                    ->paintProperties()
                    ->scroll()
-                   ->hasMainThreadScrollingReasons(
-                       MainThreadScrollingReason::kThreadedScrollingDisabled));
+                   ->threadedScrollingDisabled());
 
   document().settings()->setThreadedScrollingEnabled(false);
+  // TODO(pdr): The main thread scrolling setting should invalidate properties.

[Xianzhu, 2016/11/17 19:03:04]

The TODO is fine. Just curious, should we make it a RuntimeEnabledFlag for
simplicity?

[pdr., 2016/11/17 21:01:36]

I want to remove it entirely but that was shot down. It is only used for testing
though, see: https://bugs.chromium.org/p/chromium/issues/detail?id=410974#c45

+  document().view()->setNeedsPaintPropertyUpdate();
+  overflowA->layoutObject()->setNeedsPaintPropertyUpdate();
   document().view()->updateAllLifecyclePhases();
 
-  EXPECT_TRUE(frameScroll()->hasMainThreadScrollingReasons(
-      MainThreadScrollingReason::kThreadedScrollingDisabled));
+  EXPECT_TRUE(frameScroll()->threadedScrollingDisabled());
   EXPECT_TRUE(overflowA->layoutObject()
                   ->paintProperties()
                   ->scroll()
-                  ->hasMainThreadScrollingReasons(
-                      MainThreadScrollingReason::kThreadedScrollingDisabled));
+                  ->threadedScrollingDisabled());
 }
 
-// Disabled due to missing main thread scrolling property invalidation support.
-// See: https://crbug.com/664672
-TEST_P(
-    PaintPropertyTreeBuilderTest,
-    DISABLED_BackgroundAttachmentFixedMainThreadScrollReasonsWithNestedScrollers) {
+TEST_P(PaintPropertyTreeBuilderTest,
+       BackgroundAttachmentFixedMainThreadScrollReasonsWithNestedScrollers) {
   setBodyInnerHTML(
       "<style>"
       "  #overflowA {"
       "    position: absolute;"
       "    overflow: scroll;"
       "    width: 20px;"
       "    height: 20px;"
       "  }"
       "  #overflowB {"
       "    position: absolute;"
@@ skipping 12 matching lines @@
       "<div id='overflowA'>"
       "  <div id='overflowB' class='backgroundAttachmentFixed'>"
       "    <div class='forceScroll'></div>"
       "  </div>"
       "  <div class='forceScroll'></div>"
       "</div>"
       "<div class='forceScroll'></div>");
   Element* overflowA = document().getElementById("overflowA");
   Element* overflowB = document().getElementById("overflowB");
 
-  EXPECT_TRUE(frameScroll()->hasMainThreadScrollingReasons(
-      MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
-  EXPECT_TRUE(
-      overflowA->layoutObject()
-          ->paintProperties()
-          ->scroll()
-          ->hasMainThreadScrollingReasons(
-              MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
-  EXPECT_FALSE(
-      overflowB->layoutObject()
-          ->paintProperties()
-          ->scroll()
-          ->hasMainThreadScrollingReasons(
-              MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
+  EXPECT_TRUE(frameScroll()->hasBackgroundAttachmentFixedDescendants());
+  EXPECT_TRUE(overflowA->layoutObject()
+                  ->paintProperties()
+                  ->scroll()
+                  ->hasBackgroundAttachmentFixedDescendants());
+  EXPECT_FALSE(overflowB->layoutObject()
+                   ->paintProperties()
+                   ->scroll()
+                   ->hasBackgroundAttachmentFixedDescendants());
 
   // Removing a main thread scrolling reason should update the entire tree.
   overflowB->removeAttribute("class");
   document().view()->updateAllLifecyclePhases();
-  EXPECT_FALSE(frameScroll()->hasMainThreadScrollingReasons(
-      MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
-  EXPECT_FALSE(
-      overflowA->layoutObject()
-          ->paintProperties()
-          ->scroll()
-          ->hasMainThreadScrollingReasons(
-              MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
-  EXPECT_FALSE(
-      overflowB->layoutObject()
-          ->paintProperties()
-          ->scroll()
-          ->hasMainThreadScrollingReasons(
-              MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
+  EXPECT_FALSE(frameScroll()->hasBackgroundAttachmentFixedDescendants());
+  EXPECT_FALSE(overflowA->layoutObject()
+                   ->paintProperties()
+                   ->scroll()
+                   ->hasBackgroundAttachmentFixedDescendants());
+  EXPECT_FALSE(overflowB->layoutObject()
+                   ->paintProperties()
+                   ->scroll()
+                   ->hasBackgroundAttachmentFixedDescendants());
 
   // Adding a main thread scrolling reason should update the entire tree.
   overflowB->setAttribute(HTMLNames::classAttr, "backgroundAttachmentFixed");
   document().view()->updateAllLifecyclePhases();
-  EXPECT_TRUE(frameScroll()->hasMainThreadScrollingReasons(
-      MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
-  EXPECT_TRUE(
-      overflowA->layoutObject()
-          ->paintProperties()
-          ->scroll()
-          ->hasMainThreadScrollingReasons(
-              MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
-  EXPECT_FALSE(
-      overflowB->layoutObject()
-          ->paintProperties()
-          ->scroll()
-          ->hasMainThreadScrollingReasons(
-              MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
+  EXPECT_TRUE(frameScroll()->hasBackgroundAttachmentFixedDescendants());
+  EXPECT_TRUE(overflowA->layoutObject()
+                  ->paintProperties()
+                  ->scroll()
+                  ->hasBackgroundAttachmentFixedDescendants());
+  EXPECT_FALSE(overflowB->layoutObject()
+                   ->paintProperties()
+                   ->scroll()
+                   ->hasBackgroundAttachmentFixedDescendants());
 }
 
-// Disabled due to missing main thread scrolling property invalidation support.
-// See: https://crbug.com/664672
-TEST_P(
-    PaintPropertyTreeBuilderTest,
-    DISABLED_BackgroundAttachmentFixedMainThreadScrollReasonsWithFixedScroller) {
+TEST_P(PaintPropertyTreeBuilderTest,
+       BackgroundAttachmentFixedMainThreadScrollReasonsWithFixedScroller) {
   setBodyInnerHTML(
       "<style>"
       "  #overflowA {"
       "    position: absolute;"
       "    overflow: scroll;"
       "    width: 20px;"
       "    height: 20px;"
       "  }"
       "  #overflowB {"
       "    position: fixed;"
@@ skipping 12 matching lines @@
       "<div id='overflowA'>"
       "  <div id='overflowB' class='backgroundAttachmentFixed'>"
       "    <div class='forceScroll'></div>"
       "  </div>"
       "  <div class='forceScroll'></div>"
       "</div>"
       "<div class='forceScroll'></div>");
   Element* overflowA = document().getElementById("overflowA");
   Element* overflowB = document().getElementById("overflowB");
 
-  EXPECT_FALSE(
-      overflowA->layoutObject()
-          ->paintProperties()
-          ->scroll()
-          ->hasMainThreadScrollingReasons(
-              MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
-  EXPECT_FALSE(
-      overflowB->layoutObject()
-          ->paintProperties()
-          ->scroll()
-          ->hasMainThreadScrollingReasons(
-              MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
-  EXPECT_TRUE(
-      overflowB->layoutObject()
-          ->paintProperties()
-          ->scroll()
-          ->parent()
-          ->hasMainThreadScrollingReasons(
-              MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
+  // This should be false. We are not as strict about main thread scrolling
+  // reasons as we could be.
+  EXPECT_TRUE(overflowA->layoutObject()
+                  ->paintProperties()
+                  ->scroll()
+                  ->hasBackgroundAttachmentFixedDescendants());
+  EXPECT_FALSE(overflowB->layoutObject()
+                   ->paintProperties()
+                   ->scroll()
+                   ->hasBackgroundAttachmentFixedDescendants());
+  EXPECT_TRUE(overflowB->layoutObject()
+                  ->paintProperties()
+                  ->scroll()
+                  ->parent()
+                  ->isRoot());
 
   // Removing a main thread scrolling reason should update the entire tree.
   overflowB->removeAttribute("class");
   document().view()->updateAllLifecyclePhases();
-  EXPECT_FALSE(
-      overflowA->layoutObject()
-          ->paintProperties()
-          ->scroll()
-          ->hasMainThreadScrollingReasons(
-              MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
-  EXPECT_FALSE(
-      overflowB->layoutObject()
-          ->paintProperties()
-          ->scroll()
-          ->hasMainThreadScrollingReasons(
-              MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
-  EXPECT_FALSE(
-      overflowB->layoutObject()
-          ->paintProperties()
-          ->scroll()
-          ->parent()
-          ->hasMainThreadScrollingReasons(
-              MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects));
+  EXPECT_FALSE(overflowA->layoutObject()
+                   ->paintProperties()
+                   ->scroll()
+                   ->hasBackgroundAttachmentFixedDescendants());
+  EXPECT_FALSE(overflowB->layoutObject()
+                   ->paintProperties()
+                   ->scroll()
+                   ->hasBackgroundAttachmentFixedDescendants());
+  EXPECT_FALSE(overflowB->layoutObject()
+                   ->paintProperties()
+                   ->scroll()
+                   ->parent()
+                   ->hasBackgroundAttachmentFixedDescendants());
 }
 
 TEST_P(PaintPropertyTreeBuilderTest, PaintOffsetsUnderMultiColumn) {
   setBodyInnerHTML(
       "<style>"
       "  body { margin: 0; }"
       "  .space { height: 30px; }"
       "  .abs { position: absolute; width: 20px; height: 20px; }"
       "</style>"
       "<div style='columns:2; width: 200px; column-gap: 0'>"
@@ skipping 109 matching lines @@
   EXPECT_EQ(framePreTranslation(),
             childProperties->paintOffsetTranslation()->parent());
   EXPECT_EQ(childProperties->paintOffsetTranslation(),
             childPaintState.transform());
   // This will change once we added clip expansion node.
   EXPECT_EQ(filterProperties->effect()->outputClip(), childPaintState.clip());
   EXPECT_EQ(filterProperties->effect(), childPaintState.effect());
 }
 
 }  // namespace blink