Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2506303002: Revert of Add a NetworkQualityEstimator to TestURLRequestContext. (Closed)

Created:
4 years, 1 month ago by eroman
Modified:
4 years, 1 month ago
Reviewers:
palmer, Ted C, mmenke, tbansal1
CC:
cbentzel+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a NetworkQualityEstimator to TestURLRequestContext. (patchset #8 id:140001 of https://codereview.chromium.org/2484323002/ ) Reason for revert: May be the cause of increase net_unittests flake, speculatively reverting (see comment #20) BUG=665686 Original issue's description: > Add a NetworkQualityEstimator to TestURLRequestContext. > > This was inspired by a bug in exercised NetworkQualityEstimator NQE codepath, > though this CL would not have caught the issue. > > BUG=663456 > > Committed: https://crrev.com/5ce3e1f8fef0f96ae28a09ac0aba2dc49802f9ee > Cr-Commit-Position: refs/heads/master@{#432277} TBR=palmer@chromium.org,tbansal@chromium.org,tedchoc@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=663456 Committed: https://crrev.com/726737874f2c77c0155872c6963bd86ccc971ff7 Cr-Commit-Position: refs/heads/master@{#432777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -117 lines) Patch
M chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc View 5 chunks +3 lines, -9 lines 0 comments Download
M content/browser/android/url_request_content_job_unittest.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M net/http/http_transaction_test_util.h View 2 chunks +0 lines, -3 lines 0 comments Download
M net/http/http_transaction_test_util.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 14 chunks +33 lines, -78 lines 0 comments Download
M net/url_request/url_request_test_util.h View 2 chunks +0 lines, -3 lines 0 comments Download
M net/url_request/url_request_test_util.cc View 5 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
eroman
Created Revert of Add a NetworkQualityEstimator to TestURLRequestContext.
4 years, 1 month ago (2016-11-17 02:12:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506303002/1
4 years, 1 month ago (2016-11-17 02:13:49 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_clang_dbg_recipe on ...
4 years, 1 month ago (2016-11-17 04:16:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506303002/1
4 years, 1 month ago (2016-11-17 05:55:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 06:00:21 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 06:03:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/726737874f2c77c0155872c6963bd86ccc971ff7
Cr-Commit-Position: refs/heads/master@{#432777}

Powered by Google App Engine
This is Rietveld 408576698