Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2506253007: [ObjC ARC] Converts ios/chrome/browser/voice:unit_tests to ARC.Automatically generated ARCMigrate… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/voice:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/9077bce9ccad2863d39424b04b9fd490e3f3ba4a Cr-Commit-Position: refs/heads/master@{#433884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M ios/chrome/browser/voice/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/voice/text_to_speech_listener_unittest.mm View 3 chunks +6 lines, -2 lines 0 comments Download
M ios/chrome/browser/voice/text_to_speech_parser_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL. Passes downstream tests.
4 years, 1 month ago (2016-11-21 11:59:57 UTC) #6
kkhorimoto
lgtm
4 years, 1 month ago (2016-11-21 19:23:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506253007/1
4 years, 1 month ago (2016-11-22 14:24:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 16:43:08 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 16:47:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9077bce9ccad2863d39424b04b9fd490e3f3ba4a
Cr-Commit-Position: refs/heads/master@{#433884}

Powered by Google App Engine
This is Rietveld 408576698